2817 enable shorthands for lodash (#2818)

* * Update webpack-dev-server to "^3.2.0" in package.json with generated yarn.lock file

* * Update webpack-dev-server to "^3.2.0" in package.json with generated yarn.lock file

Signed-off-by: cpretzer <charles@buoyant.io>

* * #2817 enable shorthands for lodash

Signed-off-by: cpretzer <charles@buoyant.io>

* * #2817 enable shorthands for lodash

Signed-off-by: cpretzer <charles@buoyant.io>

* Pin webpack-dev-server to version 3.3.1

Signed-off-by: Charles Pretzer <charles@buoyant.io>

* Subject:
Remove unnecessary linting configs and rules for lodash

Problem:
Work related to supporting newer versions of node allows for the removal of lodash linting

Solution:
Remove lodash lint rules
Remove eslint-plugin-lodash from package.json
Remove lodash from plugins section of .eslintrc

Validation:
Ran all build commands (setup, dev, and run) with node versions 12 and 10

Fixes #2817 #2809

Signed-off-by: Charles Pretzer <charles@buoyant.io>

* Signed-off-by: Charles Pretzer <charles@buoyant.io>

Update yarn.lock after merge with master

web/app/.eslintrc

@@ -1,8 +1,7 @@
 {
   "plugins": [
     "react",
-    "promise",
-    "lodash"
+    "promise"
   ],
   "parser": "babel-eslint",
   "parserOptions": {
@@ -35,9 +34,6 @@
     "jsx-a11y/click-events-have-key-events": 0,
     "jsx-quotes": 2,
     "keyword-spacing": 2,
-    "lodash/matches-shorthand": [2, "never"],
-    "lodash/matches-prop-shorthand": [2, "never"],
-    "lodash/prop-shorthand": [2, "never"],
     "no-console": [1, { "allow": ["warn", "error"] }], // minor offense
     "no-restricted-imports": [2, "lodash"],
     "no-trailing-spaces": 2,

web/app/package.json

@@ -48,7 +48,6 @@
     "eslint-loader": "2.0.0",
     "eslint-plugin-import": "2.12.0",
     "eslint-plugin-jsx-a11y": "6.0.3",
-    "eslint-plugin-lodash": "5.1.0",
     "eslint-plugin-promise": "3.6.0",
     "eslint-plugin-react": "7.11.1",
     "file-loader": "2.0.0",
@@ -68,7 +67,7 @@
     "webpack": "4.20.2",
     "webpack-bundle-analyzer": "^3.3.2",
     "webpack-cli": "3.0.7",
-    "webpack-dev-server": "3.1.14"
+    "webpack-dev-server": "3.3.1"
   },
   "jest": {
     "testEnvironment": "enzyme",

web/app/webpack.config.js

@@ -70,7 +70,8 @@ module.exports = {
     new LodashModuleReplacementPlugin({
       // 'chain': true,
       'collections': true,
-      'paths': true
+      'paths': true,
+      'shorthands': true
     }),
     // compile the bundle with hashed filename into index_bundle.js.out
     new HtmlWebpackPlugin({