linkerd
/
linkerd2
mirror of https://github.com/linkerd/linkerd2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Set heartbeat cronjobs to not restart on failure (#3174) 

The heartbeat cronjob specified `restartPolicy: OnFailure`. In cases
where failure was non-transient, such as if a cluster did not have
internet access, this would continuously restart and fail.

Change the heartbeat cronjob to `restartPolicy: Never`, as a failed job
has no user-facing impact.

Signed-off-by: Andrew Seigner <siggy@buoyant.io>
This commit is contained in:
Andrew Seigner 2019-07-31 13:51:13 -07:00 committed by GitHub
parent 6cc52c3363
commit a8830b2323
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
9 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
chart/templates/heartbeat.yaml
View File

@ -26,7 +26,7 @@ spec:
{{.CreatedByAnnotation}}: {{.CliVersion}}
spec:
serviceAccountName: linkerd-heartbeat
restartPolicy: OnFailure
restartPolicy: Never
containers:
- name: heartbeat
image: {{.ControllerImage}}

2
cli/cmd/testdata/install_control-plane.golden vendored
View File

@ -527,7 +527,7 @@ spec:
linkerd.io/created-by: linkerd/cli dev-undefined
spec:
serviceAccountName: linkerd-heartbeat
restartPolicy: OnFailure
restartPolicy: Never
containers:
- name: heartbeat
image: gcr.io/linkerd-io/controller:install-control-plane-version

2
cli/cmd/testdata/install_default.golden vendored
View File

@ -1115,7 +1115,7 @@ spec:
linkerd.io/created-by: linkerd/cli dev-undefined
spec:
serviceAccountName: linkerd-heartbeat
restartPolicy: OnFailure
restartPolicy: Never
containers:
- name: heartbeat
image: gcr.io/linkerd-io/controller:install-control-plane-version

2
cli/cmd/testdata/install_ha_output.golden vendored
View File

@ -1185,7 +1185,7 @@ spec:
linkerd.io/created-by: linkerd/cli dev-undefined
spec:
serviceAccountName: linkerd-heartbeat
restartPolicy: OnFailure
restartPolicy: Never
containers:
- name: heartbeat
image: gcr.io/linkerd-io/controller:install-control-plane-version

2
cli/cmd/testdata/install_ha_with_overrides_output.golden vendored
View File

@ -1185,7 +1185,7 @@ spec:
linkerd.io/created-by: linkerd/cli dev-undefined
spec:
serviceAccountName: linkerd-heartbeat
restartPolicy: OnFailure
restartPolicy: Never
containers:
- name: heartbeat
image: gcr.io/linkerd-io/controller:install-control-plane-version

2
cli/cmd/testdata/install_no_init_container.golden vendored
View File

@ -1046,7 +1046,7 @@ spec:
linkerd.io/created-by: linkerd/cli dev-undefined
spec:
serviceAccountName: linkerd-heartbeat
restartPolicy: OnFailure
restartPolicy: Never
containers:
- name: heartbeat
image: gcr.io/linkerd-io/controller:install-control-plane-version

2
cli/cmd/testdata/install_output.golden vendored
View File

@ -1041,7 +1041,7 @@ spec:
CreatedByAnnotation: CliVersion
spec:
serviceAccountName: linkerd-heartbeat
restartPolicy: OnFailure
restartPolicy: Never
containers:
- name: heartbeat
image: ControllerImage

2
cli/cmd/testdata/upgrade_default.golden vendored
View File

@ -1117,7 +1117,7 @@ spec:
linkerd.io/created-by: linkerd/cli dev-undefined
spec:
serviceAccountName: linkerd-heartbeat
restartPolicy: OnFailure
restartPolicy: Never
containers:
- name: heartbeat
image: gcr.io/linkerd-io/controller:UPGRADE-CONTROL-PLANE-VERSION

2
cli/cmd/testdata/upgrade_ha.golden vendored
View File

@ -1187,7 +1187,7 @@ spec:
linkerd.io/created-by: linkerd/cli dev-undefined
spec:
serviceAccountName: linkerd-heartbeat
restartPolicy: OnFailure
restartPolicy: Never
containers:
- name: heartbeat
image: gcr.io/linkerd-io/controller:UPGRADE-CONTROL-PLANE-VERSION