Remove no longer needed GITCOOKIE_SH in CI (#4881)

Removed usage of `GITCOOKIE_SH`, which was a script stored in a secret
to authenticate requests against googlesource.com, to avoid hitting
rate limits when pulling go dependencies from that source. Now that we
use go modules, deps are pulled from http://proxy.golang.org/ and this
is no longer needed.
This commit is contained in:
Alejandro Pedraza 2020-08-17 14:36:07 -05:00 committed by GitHub
parent c25f0a3af5
commit ac2bfb387b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 23 deletions

View File

@ -100,11 +100,7 @@ jobs:
name: testing-${{ env.TAG }}-${{ github.run_id }} name: testing-${{ env.TAG }}-${{ github.run_id }}
num_nodes: 2 num_nodes: 2
- name: Run integration tests - name: Run integration tests
env: run: bin/tests --skip-kind-create "$CMD"
GITCOOKIE_SH: ${{ secrets.GITCOOKIE_SH }}
run: |
echo "$GITCOOKIE_SH" | bash
bin/tests --skip-kind-create "$CMD"
- name: CNI tests - name: CNI tests
run: | run: |
export TAG="$($CMD version --client --short)" export TAG="$($CMD version --client --short)"

View File

@ -183,11 +183,7 @@ jobs:
name: testing-${{ steps.install_cli.outputs.tag }}-${{ github.run_id }} name: testing-${{ steps.install_cli.outputs.tag }}-${{ github.run_id }}
num_nodes: 2 num_nodes: 2
- name: Run integration tests - name: Run integration tests
env: run: bin/tests --skip-kind-create "$CMD"
GITCOOKIE_SH: ${{ secrets.GITCOOKIE_SH }}
run: |
echo "$GITCOOKIE_SH" | bash
bin/tests --skip-kind-create "$CMD"
- name: CNI tests - name: CNI tests
run: | run: |
export TAG="$($CMD version --client --short)" export TAG="$($CMD version --client --short)"

View File

@ -18,11 +18,7 @@ jobs:
# actions/checkout@v2 # actions/checkout@v2
uses: actions/checkout@722adc6 uses: actions/checkout@722adc6
- name: Go lint - name: Go lint
env: run: bin/lint --verbose
GITCOOKIE_SH: ${{ secrets.GITCOOKIE_SH }}
run: |
echo "$GITCOOKIE_SH" | bash
bin/lint --verbose
go_format: go_format:
name: Go format name: Go format
runs-on: ubuntu-18.04 runs-on: ubuntu-18.04
@ -33,11 +29,7 @@ jobs:
# actions/checkout@v2 # actions/checkout@v2
uses: actions/checkout@722adc6 uses: actions/checkout@722adc6
- name: Format - name: Format
env: run: bin/fmt
GITCOOKIE_SH: ${{ secrets.GITCOOKIE_SH }}
run: |
echo "$GITCOOKIE_SH" | bash
bin/fmt
shellcheck: shellcheck:
name: shellcheck name: shellcheck
runs-on: ubuntu-18.04 runs-on: ubuntu-18.04

View File

@ -18,10 +18,7 @@ jobs:
# actions/checkout@v2 # actions/checkout@v2
uses: actions/checkout@722adc6 uses: actions/checkout@722adc6
- name: Go unit tests - name: Go unit tests
env:
GITCOOKIE_SH: ${{ secrets.GITCOOKIE_SH }}
run: | run: |
echo "$GITCOOKIE_SH" | bash
go get gotest.tools/gotestsum@v0.4.2 go get gotest.tools/gotestsum@v0.4.2
# TODO: validate bin/protoc-go.sh does not dirty the repo # TODO: validate bin/protoc-go.sh does not dirty the repo
gotestsum -- -cover -race -v -mod=readonly ./... gotestsum -- -cover -race -v -mod=readonly ./...