From b010b5868006f95337f8ecab97b25ce1e78b03f6 Mon Sep 17 00:00:00 2001 From: Oliver Gould Date: Tue, 26 Sep 2023 15:07:46 -0700 Subject: [PATCH] viz: Fix jaeger check test (#11425) 64b66f921 changed the behavior of healthcheck.CheckProxyVersionsUpToDate so that it errors when there are no channels provided. The viz tracing test uses this utility to generate the expected error message, and it did so without providing any channels. This regression is fixed by instantiating the Channels struct with data. --- test/integration/viz/tracing/tracing_test.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/test/integration/viz/tracing/tracing_test.go b/test/integration/viz/tracing/tracing_test.go index 08ea94c67..0911d829d 100644 --- a/test/integration/viz/tracing/tracing_test.go +++ b/test/integration/viz/tracing/tracing_test.go @@ -80,7 +80,11 @@ func TestTracing(t *testing.T) { } tpl := template.Must(template.ParseFiles("testdata" + "/" + golden)) - versionErr := healthcheck.CheckProxyVersionsUpToDate(pods, version.Channels{}) + chs, err := version.NewChannels("test-99.88.77") + if err != nil { + panic(err.Error()) + } + versionErr := healthcheck.CheckProxyVersionsUpToDate(pods, chs) versionErrMsg := "" if versionErr != nil { versionErrMsg = versionErr.Error()