From b6aad75b35993d0f355c59c26302bc72adb0afbb Mon Sep 17 00:00:00 2001 From: Kevin Leimkuhler Date: Wed, 15 Apr 2020 09:41:06 -0700 Subject: [PATCH] Add `operationID` field to tap openapi response (#4245) This fixes an issue users are experiencing when upgrading from from Linkerd 2.6 to 2.7 and use the [kubernetes-external-secrets]() project. The change introduced by #3700 resulted in the tap service showing up in the `/openapi/v2` API response. I confirmed this with a local build. A dependency within the project expects the `operationID` field to be present in the swagger definition. It is optional as stated in the [spec](https://swagger.io/docs/specification/paths-and-operations/). It's purpose is to identify an operation and should be unique. This change adds that field to tap service swagger spec. While this can be fixed in the KES dependency, it certainly does not hurt to add and other libraries may similarly expect this field. Signed-off-by: Kevin Leimkuhler --- controller/tap/handlers.go | 1 + 1 file changed, 1 insertion(+) diff --git a/controller/tap/handlers.go b/controller/tap/handlers.go index d5100d384..1250f9277 100644 --- a/controller/tap/handlers.go +++ b/controller/tap/handlers.go @@ -330,6 +330,7 @@ func mkPathItem(desc string) spec.PathItem { }, }, }, + ID: "tapResourceV0", }, }, },