linkerd
/
linkerd2
mirror of https://github.com/linkerd/linkerd2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Enable dashboard test (#5486) 

This test was never broken. My best guess is that CI was not merging with the
latest `main` as we have recently noticed, so this was an issue that was fixed
by #5458

Closes #5478

Signed-off-by: Kevin Leimkuhler <kevin@kleimkuhler.com>
This commit is contained in:
Kevin Leimkuhler 2021-01-06 17:49:16 -05:00 committed by GitHub
parent 68c02d82d1
commit b85928e73c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
test/integration/install_test.go
View File

@ -4,6 +4,7 @@ import (
"context" "context"
"fmt" "fmt"
"os" "os"
"strconv"
"strings" "strings"
"testing" "testing"
"time" "time"
@ -613,6 +614,7 @@ func TestUpgradeHelm(t *testing.T) {
"--set", "dashboard.image.tag=" + TestHelper.GetVersion(), "--set", "dashboard.image.tag=" + TestHelper.GetVersion(),
"--set", "grafana.image.tag=" + TestHelper.GetVersion(), "--set", "grafana.image.tag=" + TestHelper.GetVersion(),
"--set", "tap.image.tag=" + TestHelper.GetVersion(), "--set", "tap.image.tag=" + TestHelper.GetVersion(),
"--wait",
} }
// Install Viz Extension Chart // Install Viz Extension Chart
if stdout, stderr, err := TestHelper.HelmInstallPlain(vizChart, "l5d-viz", vizArgs...); err != nil { if stdout, stderr, err := TestHelper.HelmInstallPlain(vizChart, "l5d-viz", vizArgs...); err != nil {
@ -813,10 +815,6 @@ func TestInstallSP(t *testing.T) {
} }
} }
// This test fails because no web component is installed during this phase of
// the extension split. It should be renabled after the issue below is closed.
// Issue: https://github.com/linkerd/linkerd2/issues/5478
/*
func TestDashboard(t *testing.T) { func TestDashboard(t *testing.T) {
dashboardPort := 52237 dashboardPort := 52237
dashboardURL := fmt.Sprintf("http://localhost:%d", dashboardPort) dashboardURL := fmt.Sprintf("http://localhost:%d", dashboardPort)
@ -853,7 +851,6 @@ func TestDashboard(t *testing.T) {
resp, TestHelper.GetVersion()) resp, TestHelper.GetVersion())
} }
} }
*/
func TestInject(t *testing.T) { func TestInject(t *testing.T) {
resources, err := testutil.ReadFile("testdata/smoke_test.yaml") resources, err := testutil.ReadFile("testdata/smoke_test.yaml")