linkerd
/
linkerd2
mirror of https://github.com/linkerd/linkerd2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix success rate not appearing in Top column (#1816) 

* Fix success rate mini chart not appearing on Top event tables

* Fix success rates being left aligned
This commit is contained in:
Risha Mars 2018-10-26 14:40:27 -07:00 committed by GitHub
parent c59f43d827
commit d2f847a484
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
web/app/js/components/TopEventTable.jsx
View File

@ -3,9 +3,9 @@ import { directionColumn, srcDstColumn, tapLink } from './util/TapUtils.jsx';
import BaseTable from './BaseTable.jsx';
import PropTypes from 'prop-types';
import React from 'react';
import SuccessRateMiniChart from './util/SuccessRateMiniChart.jsx';
import _ from 'lodash';
import { formatLatencySec } from './util/Utils.js';
import { successRateWithMiniChart } from './util/MetricUtils.jsx';
import { withContext } from './util/AppContext.jsx';
const topColumns = (resourceType, ResourceLink, PrefixedLink) => [
@ -57,7 +57,8 @@ const topColumns = (resourceType, ResourceLink, PrefixedLink) => [
title: "Success Rate",
key: "successRate",
isNumeric: true,
render: d => _.isNil(d) || !d.get ? "---" : successRateWithMiniChart(d.get())
render: d => _.isNil(d) || _.isNil(d.successRate) ? "---" :
<SuccessRateMiniChart sr={d.successRate.get()} />
},
{
title: "Tap",

2
web/app/js/components/util/SuccessRateMiniChart.jsx
View File

@ -10,7 +10,7 @@ class SuccessRateMiniChart extends React.Component {
const { sr } = this.props;
return (
<Grid container alignItems="center" spacing={8}>
<Grid container justify="flex-end" alignItems="center" spacing={8}>
<Grid item>{metricToFormatter["SUCCESS_RATE"](sr)}</Grid>
<Grid item>{_.isNil(sr) ? null :
<SuccessRateDot sr={sr} />