Bump golangci-lint to 1.17.1 (#3150)

Also add `bodyclose` linter

Signed-off-by: Andrew Seigner <siggy@buoyant.io>

.golangci.yml

@@ -1,7 +1,7 @@
 # This file specifies which linters golangci-lint should run.
 #
 # For descriptions of all available linters, run:
-# ./.golangci-lint-1.15.0 linters
+# ./.golangci-lint-1.17.1 linters
 # or browse to:
 # https://github.com/golangci/golangci-lint#supported-linters
 
@@ -11,6 +11,7 @@ issues:
   exclude-use-default: false
 linters:
   enable:
+  - bodyclose
   - deadcode
   - depguard
   - goconst

bin/lint

@@ -2,7 +2,7 @@
 
 set -eu
 
-lintversion=1.15.0
+lintversion=1.17.1
 
 cd "$(pwd -P)"
 

pkg/inject/inject_test.go

@@ -93,7 +93,7 @@ func TestConfigAccessors(t *testing.T) {
 		{id: "use overrides",
 			spec: appsv1.DeploymentSpec{
 				Template: corev1.PodTemplateSpec{
-					metav1.ObjectMeta{
+					ObjectMeta: metav1.ObjectMeta{
 						Annotations: map[string]string{
 							k8s.ProxyDisableIdentityAnnotation:        "true",
 							k8s.ProxyImageAnnotation:                  "gcr.io/linkerd-io/proxy",
@@ -114,7 +114,7 @@ func TestConfigAccessors(t *testing.T) {
 							k8s.ProxyEnableExternalProfilesAnnotation: "false",
 							k8s.ProxyVersionOverrideAnnotation:        proxyVersionOverride},
 					},
-					corev1.PodSpec{},
+					Spec: corev1.PodSpec{},
 				},
 			},
 			expected: expectedProxyConfigs{
@@ -178,8 +178,8 @@ func TestConfigAccessors(t *testing.T) {
 		{id: "use defaults",
 			spec: appsv1.DeploymentSpec{
 				Template: corev1.PodTemplateSpec{
-					metav1.ObjectMeta{},
-					corev1.PodSpec{},
+					ObjectMeta: metav1.ObjectMeta{},
+					Spec:       corev1.PodSpec{},
 				},
 			},
 			expected: expectedProxyConfigs{