linkerd
/
linkerd2
mirror of https://github.com/linkerd/linkerd2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix incorrect usage of --skip-kind-create flag (#5084) 

The release workflow uses the `-skip-kind-create` flag when the flag is actually called `-skip-cluster-create`.  This causes the workflow to fail.

We correct the flag name.

Signed-off-by: Alex Leong <alex@buoyant.io>
This commit is contained in:
Alex Leong 2020-10-14 11:30:27 -07:00 committed by GitHub
parent eccc6d1214
commit fbc405d5b4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/release.yml vendored
View File

@ -171,7 +171,7 @@ jobs:
#if: startsWith(github.ref, 'refs/tags/stable')
env:
RUN_ARM_TEST: 1
run: bin/tests --images skip --skip-kind-create "$CMD"
run: bin/tests --images skip --skip-cluster-create "$CMD"
- name: CNI tests
#if: startsWith(github.ref, 'refs/tags/stable')
run: |

6
TEST.md
View File

@ -102,7 +102,7 @@ are no prerequisites for this test path.
### Prerequisites for existing cluster
If integration tests should run on an existing Kubernetes cluster, then the
`--skip-kind-create` flag should be passed. This will disable the tests from
`--skip-cluster-create` flag should be passed. This will disable the tests from
creating their own clusters and instead use the current Kubernetes context.
In this case, ensure the following:
@ -125,7 +125,7 @@ Optional flags can be passed that change the testing behavior:
- `--name`: Pass an argument with this flag to specify a specific test that
should be run; all tests are run in the absence of this flag. Valid test names
are included in the `bin/tests --help` output
- `--skip-kind-create`: Skip KinD cluster creation for each test and use an
- `--skip-cluster-create`: Skip KinD cluster creation for each test and use an
existing Kubernetes cluster
- `--images`: (Primarily for CI) Loads images from the `image-archive/`
directory into the KinD clusters created for each test
@ -179,7 +179,7 @@ bin/tests $PWD/bin/linkerd
```
**Note**: As stated above, if running tests in an existing KinD cluster by
passing `--skip-kind-create`, `bin/kind-load` must be run so that the images are
passing `--skip-cluster-create`, `bin/kind-load` must be run so that the images are
available to the cluster
#### Testing the dashboard