linkerd2

Commit Graph

Author	SHA1	Message	Date
Andrew Seigner	1c302182ef	Enable lint check for comments (#2023 ) Commit 1: Enable lint check for comments Part of #217. Follow up from #1982 and #2018. A subsequent commit will fix the ci failure. Commit 2: Address all comment-related linter errors. This change addresses all comment-related linter errors by doing the following: - Add comments to exported symbols - Make some exported symbols private - Recommend via TODOs that some exported symbols should should move or be removed This PR does not: - Modify, move, or remove any code - Modify existing comments Signed-off-by: Andrew Seigner <siggy@buoyant.io>	2019-01-02 14:03:59 -08:00
Kevin Lingerfelt	f1b0983f72	Add go linting to CI config (#2018 ) * Add go linting to CI config * Fix lint warnings * Add note about bin/lint script in TEST.md Signed-off-by: Kevin Lingerfelt <kl@buoyant.io>	2018-12-20 15:33:09 -08:00

Author

SHA1

Message

Date

Andrew Seigner

1c302182ef

Enable lint check for comments (#2023 )

Commit 1: Enable lint check for comments

Part of #217. Follow up from #1982 and #2018.

A subsequent commit will fix the ci failure.

Commit 2: Address all comment-related linter errors.

This change addresses all comment-related linter errors by doing the
following:
- Add comments to exported symbols
- Make some exported symbols private
- Recommend via TODOs that some exported symbols should should move or
  be removed

This PR does not:
- Modify, move, or remove any code
- Modify existing comments

Signed-off-by: Andrew Seigner <siggy@buoyant.io>

2019-01-02 14:03:59 -08:00

Kevin Lingerfelt

f1b0983f72

Add go linting to CI config (#2018 )

* Add go linting to CI config
* Fix lint warnings
* Add note about bin/lint script in TEST.md

Signed-off-by: Kevin Lingerfelt <kl@buoyant.io>

2018-12-20 15:33:09 -08:00

2 Commits