Commit Graph

2 Commits

Author SHA1 Message Date
Zahari Dichev b31918c8ec
chore(identity): add !windows tag in run_proxy_unix.go (#14345)
In a recent change #14307 we split the proxy running logic in the identity wrapper. It turns out that _unix suffixes are not ignored for windows builds. Therefore, we add a build tag to the file to ignore it for windows specific builds.

For context: golang/go#51572

Signed-off-by: Zahari Dichev zaharidichev@gmail.com
2025-08-11 10:43:54 -07:00
Zahari Dichev fa8d9fe092
fix(proxy-identity): use execve call on Linux to start the proxy (#14307)
A recent change (https://github.com/linkerd/linkerd2/pull/14126) altered the semantics of running the proxy from the identity wrapper. This has introduced [regression in behavior on Linux systems](https://github.com/linkerd/linkerd2/issues/14289). This PR reverts the logic on Unix to use `execve`. This way we use `os/exec` only on Windows systems. 

Further investigation into Windows behavior will be carried out but for now we aim to revert back to the behavior we had on Unix prior to https://github.com/linkerd/linkerd2/pull/14126

Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
2025-08-01 12:35:48 -07:00