linkerd2

Commit Graph

Author	SHA1	Message	Date
Joakim Roubert	377b38f0bf	bin/protoc-diff: Don't assume Debian and don't install unzip (#5347 ) - Do unzip check but don't install; leave installation to user - Move unzip check to bin/protoc that actually uses unzip - Make sure the protoc scripts can be called from any directory Fixes #5337 Signed-off-by: Joakim Roubert <joakim.roubert@axis.com>	2020-12-09 09:12:38 -05:00
Alejandro Pedraza	48666a7673	bin/shellcheck-all was missing some files (#5335 ) * bin/shellcheck-all was missing some files `bin/shellcheck-all` identifies what files to check by filtering by the `text/x-shellscript` mime-type, which only applies to files with a shebang pointing to bash. We had a number of files with a `#!/usr/bin/env sh` shebang that (at least in Ubuntu given `sh` points to `dash`) only exposes a `text/plain` mime-type, thus they were not being checked. This fixes that issue by replacing the filter in `bin/shellcheck-all`, using a simple grep over the file shebang instead of using the `file` command.	2020-12-08 09:30:52 -05:00
Zahari Dichev	2e7c00aa37	Diff generated code from proto files (#4863 ) Add a static check that ensures the generated files from the proto definitions have not changed. Fix #4669 Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>	2020-08-18 11:44:33 +03:00

Author

SHA1

Message

Date

Joakim Roubert

377b38f0bf

bin/protoc-diff: Don't assume Debian and don't install unzip (#5347 )

- Do unzip check but don't install; leave installation to user
- Move unzip check to bin/protoc that actually uses unzip
- Make sure the protoc scripts can be called from any directory

Fixes #5337

Signed-off-by: Joakim Roubert <joakim.roubert@axis.com>

2020-12-09 09:12:38 -05:00

Alejandro Pedraza

48666a7673

bin/shellcheck-all was missing some files (#5335 )

* bin/shellcheck-all was missing some files

`bin/shellcheck-all` identifies what files to check by filtering by the
`text/x-shellscript` mime-type, which only applies to files with a
shebang pointing to bash. We had a number of files with a
`#!/usr/bin/env sh` shebang that (at least in Ubuntu given `sh` points
to `dash`) only exposes a `text/plain` mime-type, thus they were not
being checked.

This fixes that issue by replacing the filter in `bin/shellcheck-all`, using a simple grep over the file shebang instead of using the `file` command.

2020-12-08 09:30:52 -05:00

Zahari Dichev

2e7c00aa37

Diff generated code from proto files (#4863 )

Add a static check that ensures the generated files from the proto definitions have not changed. 

Fix #4669

Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>

2020-08-18 11:44:33 +03:00

3 Commits