mirror of https://github.com/linkerd/linkerd2.git
0f7d684ca9
The default value for the max-rps argument to the tap and top commands is an overly conservative 1rps. This causes the data to come in very slowly and much data to be discarded. Furthermore, because tap requests are windowed to 10 seconds, this causes long pauses between updates. We fix this in two ways. Firstly we reduce the window size to 1s so that updates will come in at least once per second, even when the actual RPS of the data path is extremely high. Secondly, we increase the default max-rps parameter from 1 to 100. This allows tap to paint an accurate picture of the data much more quickly and sidesteps some sampling bias that happens when the max-rps is low. In general, tap events tend to happen in bursts. For example, one request in may trigger one or more requests out. Likewise, a single upstream event may trigger several requests to the tapped pod in quick succession. Sampling bias will occur when the max-rps is less than the actual rps and when the tap event limit subdivides these event bursts (biasing towards the first few events in the burst). The greater the max-rps, the less the effects of this bias. Fixes #1525 Signed-off-by: Alex Leong <alex@buoyant.io> |
||
|---|---|---|
| .. | ||
| testdata | ||
| check.go | ||
| check_test.go | ||
| completion.go | ||
| completion_test.go | ||
| dashboard.go | ||
| get.go | ||
| get_test.go | ||
| inject.go | ||
| inject_test.go | ||
| install.go | ||
| install_test.go | ||
| root.go | ||
| stat.go | ||
| stat_test.go | ||
| tap.go | ||
| tap_test.go | ||
| test_helper.go | ||
| top.go | ||
| version.go | ||
| version_test.go | ||