mirror of https://github.com/linkerd/linkerd2.git
Previously, we would tap any resource's pods, regardless of whether the pods were meshed or not. We can't actually tap non-meshed pods, so I'm adding a check that will filter out non-meshed pods from the pods that tap watches. Previous behaviour: When attempting to hang a non meshed pod, it would establish a watch on the pods, but then never return any results. In the CLI you could just cancel it with Ctrl-C. In the web, clicking Stop would send a WebSocket.close(1000) but wouldn't actually close the connection... Behaviour after change : If no pods under the specified resource are meshed, it'll return an error of no pods being found to tap |
||
|---|---|---|
| .. | ||
| ca | ||
| destination | ||
| proxy-api | ||
| public-api | ||
| tap | ||