mirror of https://github.com/linkerd/linkerd2.git
This PR adds a `classification` label to proxy response metrics, as @olix0r described in https://github.com/runconduit/conduit/issues/634#issuecomment-376964083. The label is either "success" or "failure", depending on the following rules: + **if** the response had a gRPC status code, *then* - gRPC status code 0 is considered a success - all others are considered failures + **else if** the response had an HTTP status code, *then* - status codes < 500 are considered success, - status codes >= 500 are considered failures + **else if** the response stream failed **then** - the response is a failure. I've also added end-to-end tests for the classification of HTTP responses (with some work towards classifying gRPC responses as well). Additionally, I've updated `doc/proxy_metrics.md` to reflect the added `classification` label. Signed-off-by: Eliza Weisman <eliza@buoyant.io> |
||
---|---|---|
.. | ||
controller-grpc | ||
convert | ||
futures-mpsc-lossy | ||
router | ||
src | ||
tests | ||
Cargo.toml | ||
Dockerfile |