mirror of https://github.com/linkerd/linkerd2.git
PR #3154 introduced an `l5d-require-id` header to Tap requests. That header string was constructed based on the TapByResourceRequest, which includes 3 notable fields (type, name, namespace). For namespace-level requests (via commands like `linkerd tap ns linkerd`), type == `namespace`, name == `linkerd`, and namespace == "". This special casing for namespace-level requests yielded invalid `l5d-require-id` headers, for example: `pd-sa..serviceaccount.identity.linkerd.cluster.local`. Fix `l5d-require-id` string generation to account for namespace-level requests. The bulk of this change is tap unit test updates to validate the fix. Signed-off-by: Andrew Seigner <siggy@buoyant.io> |
||
---|---|---|
.. | ||
watcher | ||
client.go | ||
endpoint_translator.go | ||
endpoint_translator_test.go | ||
fallback_profile_listener.go | ||
fallback_profile_listener_test.go | ||
profile_translator.go | ||
profile_translator_test.go | ||
server.go | ||
server_test.go | ||
traffic_split_adaptor.go | ||
traffic_split_adaptor_test.go |