linkerd2/cli/cmd
Brian Smith 649e784d9c
Simplify cluster zone suffix handling in the proxy (#528)
* Temporarily stop trying to support configurable zones in the proxy.

None of the zone configuration is tested and lots of things assume the cluster
zone is `cluster.local`. Further, how exactly the proxy will actually learn the
cluster zone hasn't been decided yet.

Just hard-code the zone as "cluster.local" in the proxy until configurable zones
are fully implemented and tested to be working correctly.

Signed-off-by: Brian Smith <brian@briansmith.org>

* Remove the CONDUIT_PROXY_DESTINATIONS_AUTOCOMPLETE_FQDN setting

The way that Kubernetes configures DNS search suffixes has some negative
consequences as some names like "example.com" are ambiguous: depending on
whether there is a service "example" in the "com" namespace, "example.com"
may refer to an external service or an internal service, and this can
fluctuate over time. In recognition of that we added the
CONDUIT_PROXY_DESTINATIONS_AUTOCOMPLETE_FQDN setting, thinking this would
be part of a solution for users to opt out of the unfortunate behavior
if their applications didn't depend on the DNS search suffix feature.

It turns out similar effects can be acheived using a custom dnsConfig,
starting in Kubernetes 1.10 when dnsConfig reaches the beta stability level.
Now any CONDUIT_PROXY_DESTINATIONS_AUTOCOMPLETE_FQDN-based seems duplicative.
Further, attempting to support it optionally made the code complex and hard
to read.

Therefore, let's just remove it. If/when somebody actually requests this
functionality then we can add it back, if dnsConfig isn't a valid alternative
for them.

Signed-off-by: Brian Smith <brian@briansmith.org>

* Further hard-code "cluster.local" as the zone, temporarily.

Addresses review feedback.

Signed-off-by: Brian Smith <brian@briansmith.org>
2018-03-07 14:30:13 -10:00
..
testdata Simplify cluster zone suffix handling in the proxy (#528) 2018-03-07 14:30:13 -10:00
check.go Add --expected-version flag for conduit check command (#497) 2018-03-06 11:32:14 -08:00
check_test.go Remove kubectl dependency, validate k8s server version via api (#396) 2018-02-20 12:14:11 -08:00
completion.go Add -log-level flag for install and inject commands (#239) 2018-02-01 12:38:07 -08:00
completion_test.go Add shell completion command to cli (#97) 2017-12-28 14:24:06 -08:00
dashboard.go cli: refactor k8s config to support $KUBECONFIG with multiple paths (#482) 2018-02-28 12:13:09 -08:00
dashboard_test.go add check and friendly error if conduit dashboard is not installed (#289) 2018-02-19 09:28:56 -08:00
get.go Improve get/stat/tap help text by way of examples (#401) 2018-02-20 19:27:42 -08:00
get_test.go fix typo error (#153) 2018-01-16 11:20:21 -05:00
inject.go Simplify cluster zone suffix handling in the proxy (#528) 2018-03-07 14:30:13 -10:00
inject_test.go Inject the conduit proxy into controller pod during conduit install (#365) 2018-02-23 13:55:46 -08:00
install.go Add Grafana to conduit install (#444) 2018-02-28 11:36:21 -08:00
install_test.go Add Grafana to conduit install (#444) 2018-02-28 11:36:21 -08:00
root.go cli: refactor k8s config to support $KUBECONFIG with multiple paths (#482) 2018-02-28 12:13:09 -08:00
stat.go Improve get/stat/tap help text by way of examples (#401) 2018-02-20 19:27:42 -08:00
stat_test.go Remove pod-level metrics from web and CLI (#304) 2018-02-08 19:07:10 -08:00
tap.go Improve get/stat/tap help text by way of examples (#401) 2018-02-20 19:27:42 -08:00
tap_test.go Move EosCtx to common for Tap and Telemetery (#204) 2018-01-24 15:48:00 -08:00
test_helper.go Add Grafana to conduit install (#444) 2018-02-28 11:36:21 -08:00
version.go Add --short and --client to CLI version command (#274) 2018-02-05 17:02:45 -05:00
version_test.go Update cli subcommands to print errors when encountered (#221) 2018-01-29 11:28:19 -08:00