mirror of https://github.com/linkerd/linkerd2.git
ad073c79b9
Currently, the `Reconnect` middleware does not reconnect on connection errors (see #491) and treats them as request errors. This means that when a connection timeout is wrapped in a `Reconnect`, timeout errors are treated as request errors, and the request returns HTTP 500. Since this is not the desired behavior, the connection timeouts should be removed, at least until their errors can be handled differently. This PR removes the connect timeouts from `Bind`, as described in https://github.com/runconduit/conduit/pull/483#issuecomment-369380003. It removes the `CONDUIT_PROXY_PUBLIC_CONNECT_TIMEOUT_MS` environment variable, but _not_ the `CONDUIT_PROXY_PRIVATE_CONNECT_TIMEOUT_MS` variable, since this is also used for the TCP connect timeouts. If we want also want to remove the TCP connection timeouts, I can do that as well. Closes #483. Fixes #491. |
||
|---|---|---|
| .. | ||
| controller-grpc | ||
| convert | ||
| futures-mpsc-lossy | ||
| router | ||
| src | ||
| tests | ||
| Cargo.toml | ||
| Dockerfile | ||