linkerd2/cli/cmd
Alejandro Pedraza ba9fd70892
`linkerd upgrade config` bombs when installation had a flag (#3097)
When installing using some of the flags that persist in install, e.g
`linkerd install --ha`, and then doing `linkerd upgrade config` a nil
pointer error is thrown.

Fixes #3094

`newCmdUpgradeConfig()` was using passing `flags` as nil because
`linkerd upgrade config` doesn't expose any flags for the subcommand,
but turns out they're still needed down the call stack in
`setFlagsFromInstall` to reuse the flags persisted during install.

I also added a new unit test catching this.

Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
2019-07-18 09:09:01 -05:00
..
testdata `linkerd upgrade config` bombs when installation had a flag (#3097) 2019-07-18 09:09:01 -05:00
check.go Introduce global resources checks to install and multi-stage install (#2987) 2019-06-27 09:59:12 -07:00
check_test.go Output check result as json (#2666) 2019-05-20 09:04:28 -07:00
completion.go CLI help updates: non-experimental auto-inject; unhide install-cni (#2319) 2019-02-18 15:32:46 -08:00
completion_test.go Rename CLI from conduit to linkerd (#1312) 2018-07-12 17:14:07 -07:00
dashboard.go Simplify port-forwarding code (#2976) 2019-06-26 11:14:57 -05:00
doc.go Generate CLI docs for usage by the website (#2296) 2019-02-15 13:28:31 -08:00
edges.go Updating CLI output for `linkerd edges` (#3048) 2019-07-17 12:23:34 -07:00
edges_test.go Updating CLI output for `linkerd edges` (#3048) 2019-07-17 12:23:34 -07:00
endpoints.go Have `linkerd endpoints` use `Destination.Get` (#2990) 2019-07-03 09:11:03 -05:00
endpoints_test.go Have `linkerd endpoints` use `Destination.Get` (#2990) 2019-07-03 09:11:03 -05:00
get.go cli: Consolidate the public API clients (#2527) 2019-03-19 20:52:39 -07:00
get_test.go Fix most golint issues that are not comment related (#1982) 2018-12-20 10:37:47 -08:00
inject.go linkerd inject from remote URL (#2988) 2019-06-28 09:47:33 -07:00
inject_test.go Fix inject with path and add tests (#3038) 2019-07-05 09:26:25 -05:00
inject_util.go Fix inject with path and add tests (#3038) 2019-07-05 09:26:25 -05:00
install-cni-plugin.go proxy: Upgrade to identity-capable proxy (#2524) 2019-03-19 14:20:39 -07:00
install-cni-plugin_test.go proxy: Upgrade to identity-capable proxy (#2524) 2019-03-19 14:20:39 -07:00
install-sp.go Enable `unused` linter (#2357) 2019-02-23 11:05:39 -08:00
install-sp_test.go lint: Enable scopelint (#2364) 2019-02-24 08:59:51 -08:00
install.go Update install failure message to list resources (#3050) 2019-07-09 20:21:19 +02:00
install_test.go Label all Linkerd resources (#2971) 2019-06-20 09:44:30 -07:00
logs.go Consolidate k8s APIs (#2747) 2019-04-25 11:31:38 -07:00
logs_test.go Introduce inject integration tests (#2616) 2019-04-05 11:42:49 -07:00
main_test.go Introduce inject integration tests (#2616) 2019-04-05 11:42:49 -07:00
metrics.go Simplify port-forwarding code (#2976) 2019-06-26 11:14:57 -05:00
profile.go cli: Consolidate the public API clients (#2527) 2019-03-19 20:52:39 -07:00
profile_test.go lint: Enable goconst (#2365) 2019-02-25 12:00:03 -08:00
public_api.go Consolidate k8s APIs (#2747) 2019-04-25 11:31:38 -07:00
root.go Split proxy-init into separate repo (#2824) 2019-06-03 16:24:05 -05:00
routes.go add service profile integration tests for service profile metrics (#2685) 2019-04-18 11:01:49 -07:00
routes_test.go lint: Enable goconst (#2365) 2019-02-25 12:00:03 -08:00
stat.go Show pod status more clearly (#1967) (#2989) 2019-07-10 12:44:44 -07:00
stat_test.go Show pod status more clearly (#1967) (#2989) 2019-07-10 12:44:44 -07:00
tap.go cli: Consolidate the public API clients (#2527) 2019-03-19 20:52:39 -07:00
tap_test.go lint: Enable goconst (#2365) 2019-02-25 12:00:03 -08:00
top.go cli: Consolidate the public API clients (#2527) 2019-03-19 20:52:39 -07:00
uninject.go Promote the shared injection check to the CLI and webhook (#2555) 2019-03-27 14:51:05 -07:00
uninject_test.go Check the cluster's config for install & inject (#2535) 2019-03-21 12:49:46 -07:00
upgrade.go `linkerd upgrade config` bombs when installation had a flag (#3097) 2019-07-18 09:09:01 -05:00
upgrade_test.go `linkerd upgrade config` bombs when installation had a flag (#3097) 2019-07-18 09:09:01 -05:00
version.go Use port-forwarding for linkerd CLIs (#2757) 2019-05-02 14:41:26 +02:00
version_test.go Use port-forwarding for linkerd CLIs (#2757) 2019-05-02 14:41:26 +02:00