mirror of https://github.com/linkerd/linkerd2.git
3c91fc64ce
We received a report of a panic:
runtime error: invalid memory address or nil pointer dereference
panic({0x1edb860?, 0x37a6050?}
/usr/local/go/src/runtime/panic.go:785 +0x132
github.com/linkerd/linkerd2/controller/api/destination/watcher.latestUpdated({0xc0006b2d80?, 0xc00051a540?, 0xc0008fa008?})
/linkerd-build/vendor/github.com/linkerd/linkerd2/controller/api/destination/watcher/endpoints_watcher.go:1612 +0x125
github.com/linkerd/linkerd2/controller/api/destination/watcher.(*OpaquePortsWatcher).updateService(0xc0007d5480, {0x21fd160?, 0xc000d71688?}, {0x21fd160, 0xc000d71688})
/linkerd-build/vendor/github.com/linkerd/linkerd2/controller/api/destination/watcher/opaque_ports_watcher.go:141 +0x68
The `latestUpdated` function does not properly handle the case where a atime is
omitted from a `ManagedFieldsEntry`.
type ManagedFieldsEntry struct {
// Time is the timestamp of when the ManagedFields entry was added. The
// timestamp will also be updated if a field is added, the manager
// changes any of the owned fields value or removes a field. The
// timestamp does not update when a field is removed from the entry
// because another manager took it over.
// +optional
Time *Time `json:"time,omitempty" protobuf:"bytes,4,opt,name=time"`
This change adds a check to avoid the nil dereference.
|
||
|---|---|---|
| .. | ||
| external-workload | ||
| watcher | ||
| client.go | ||
| dedup_profile_listener.go | ||
| default_profile_listener.go | ||
| destination_fuzzer.go | ||
| endpoint_profile_translator.go | ||
| endpoint_profile_translator_test.go | ||
| endpoint_translator.go | ||
| endpoint_translator_test.go | ||
| fallback_profile_listener.go | ||
| fallback_profile_listener_test.go | ||
| federated_service_watcher.go | ||
| federated_service_watcher_test.go | ||
| opaque_ports_adaptor.go | ||
| profile_translator.go | ||
| profile_translator_test.go | ||
| server.go | ||
| server_ipv6_test.go | ||
| server_test.go | ||
| syncronized_get_stream.go | ||
| test_util.go | ||