linkerd2

History

Risha Mars e63e28e243 Fix tap start/stop button not toggling at the right time (#1432 ) Problem: We depend on the websocketRequestSent bool (renamed to tapRequestInProgress in this branch) to determine whether the start/stop button says start or stop. However, we don't change this value in setState until we open the websocket connection (which could take some time). This led to a delay in when you press the Start button and when it changes colour. Solution: Set the state before waiting for the websocket to open, so the button colour changes immediately and the form feels more responsive	2018-08-10 12:12:40 -07:00
..
components	Fix tap start/stop button not toggling at the right time (#1432 )	2018-08-10 12:12:40 -07:00
index.js	Enable Tap from the Web UI (#1356 )	2018-07-24 14:23:42 -04:00

Fix tap start/stop button not toggling at the right time (#1432 )

Problem:
We depend on the websocketRequestSent bool (renamed to 
tapRequestInProgress in this branch) to determine whether the 
start/stop button says start or stop. However, we don't change 
this value in setState until we open the websocket connection 
(which could take some time). This led to a delay in when you 
press the Start button and when it changes colour.

Solution:
Set the state before waiting for the websocket to open, so the 
button colour changes immediately and the form feels more responsive

2018-08-10 12:12:40 -07:00

components

Fix tap start/stop button not toggling at the right time (#1432 )

2018-08-10 12:12:40 -07:00

index.js

Enable Tap from the Web UI (#1356 )

2018-07-24 14:23:42 -04:00