mirror of https://github.com/linkerd/linkerd2.git
f3cd0c4f27
This is in preparation for landing the Tokio upgrade. The test `discovery::outbound_updates_newer_services` currently contains an assertion that an HTTP/2 request to an HTTP/1 service will return a response with status code 500. This is because the current version of Hyper on which Conduit depends does not support protocol upgrades. However, commit hyperium/hyper@bc6af88a32, which adds support for this kind of protocol upgrade, was recently merged to Hyper's master branch. Therefore, this assertion will no longer be correct once we depend on the upcoming Hyper release. When we migrate to the new Tokio, it will be necessary to upgrade our Hyper dependency as well, and this test will fail. I've modified the test to no longer make assertions about the response's status code, so that it's compatible with both the current and future Hyper versions. If the response is not `Ok`, the test will still fail, since `tests::support::Client::request()` `expect`s that the response is successful, but the status code is ignored. I've added a comment in the test explaining this. Eventually, when the master version of Conduit depends on the latest Hyper, we may want to change this test to assert that the status code is 200 instead. We may also want to add more tests for Hyper's protocol upgrade functionality, but that seems out of scope for this PR. Signed-off-by: Eliza Weisman <eliza@buoyant.io> |
||
|---|---|---|
| .. | ||
| benches | ||
| controller-grpc | ||
| convert | ||
| futures-mpsc-lossy | ||
| router | ||
| src | ||
| tests | ||
| Cargo.toml | ||
| Dockerfile | ||
| assert_macro | ||