Removed generateName in upload YAML functionality (#2498)

* Fixed an edge case for generateName in upload YAML
* Minor fix

Signed-off-by: Amit Kumar Das <amitkumar.das@mayadata.io>
This commit is contained in:
Amit Kumar Das 2021-03-04 16:45:49 +05:30 committed by GitHub
parent 2d2ea63899
commit 105932fac2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 3 deletions

View File

@ -7,7 +7,7 @@ const useStyles = makeStyles((theme) => ({
background: theme.palette.cards.background,
height: '16rem',
width: '11.875rem',
borderRadius: '3rem',
borderRadius: 3,
fontSize: '0.875rem',
textAlign: 'center',
cursor: 'pointer',

View File

@ -103,7 +103,10 @@ const TuneWorkflow: React.FC = () => {
.then((data) => {
data.text().then((yamlText) => {
const parsedYaml = YAML.parse(yamlText);
delete parsedYaml.metadata.generateName;
// Edge case to remove the generateName Field
if (parsedYaml.metadata.generateName) {
delete parsedYaml.metadata.generateName;
}
parsedYaml.metadata.name = workflowData.name;
const modifiedYAML = changeEngineName(parsedYaml);
setYamlFile(modifiedYAML);
@ -126,7 +129,13 @@ const TuneWorkflow: React.FC = () => {
if (yaml === 'none' || yaml === '') {
fetchYaml(link);
} else {
const modifiedYAML = changeEngineName(YAML.parse(yaml));
const parsedYaml = YAML.parse(yaml);
// Edge case to remove the generateName Field
if (parsedYaml.metadata.generateName) {
delete parsedYaml.metadata.generateName;
}
parsedYaml.metadata.name = workflowData.name;
const modifiedYAML = changeEngineName(parsedYaml);
workflow.setWorkflowDetails({
yaml: modifiedYAML,
});