Added Minor updates for test identifiers for new onboarding tests + Minor CSS updates. (#2682)

* Added Minor updates for test identifiers for new onboarding tests. * Added Minor CSS updates. * Fixed deepscan issues. Signed-off-by: Jonsy13 <vedant.shrotria@chaosnative.com>
2021-04-12 19:40:25 +05:30 · 2021-04-12 19:40:25 +05:30 · 3db6cfe548
parent 4938635dec
commit 3db6cfe548
12 changed files with 47 additions and 37 deletions
--- a/litmus-portal/frontend/public/locales/en/translation.yaml
+++ b/litmus-portal/frontend/public/locales/en/translation.yaml
@ -351,7 +351,7 @@ chaosWorkflows:
      seeAnalytics: See analytics
  browseSchedules:
    name: Name
-    cluster: Cluster
+    agent: Agent
    experiments: Experiments
    schedule: Schedule
    nextRun: Next Run
@ -621,7 +621,7 @@ workflowDetailsView:
    targets:
      targetsHeader: Target
      cluster: 'Cluster :'
-      namespace: 'Namespace :'
+      namespace: 'Workflow Namespace :'
  workflowNodeInfo:
    name: Name
    type: Type
--- a/litmus-portal/frontend/src/components/Header/ProfileDropDown.tsx
+++ b/litmus-portal/frontend/src/components/Header/ProfileDropDown.tsx
@ -105,13 +105,15 @@ const ProfileDropdown: React.FC = () => {
          <div
            className={`${classes.profileDropdownRow} ${classes.profileButtons}`}
          >
-            <ButtonFilled
-              title="Logout from the portal"
-              onClick={() => logout()}
-            >
-              {t('header.profileDropdown.logout')}
-              <img id="logoutIcon" src="./icons/logout.svg" alt="logout" />
-            </ButtonFilled>
+            <div data-cy="logoutButton">
+              <ButtonFilled
+                title="Logout from the portal"
+                onClick={() => logout()}
+              >
+                {t('header.profileDropdown.logout')}
+                <img id="logoutIcon" src="./icons/logout.svg" alt="logout" />
+              </ButtonFilled>
+            </div>
            <ButtonOutlined
              title="Edit your profile"
              onClick={() => {
--- a/litmus-portal/frontend/src/pages/LoginPage/index.tsx
+++ b/litmus-portal/frontend/src/pages/LoginPage/index.tsx
@ -81,6 +81,7 @@ const LoginPage: React.FC = () => {
          >
            <div>
              <InputField
+                data-cy="inputName"
                className={classes.inputValue}
                label="Username"
                value={authData.username}
@ -100,6 +101,7 @@ const LoginPage: React.FC = () => {
                }
              />
              <InputField
+                data-cy="inputPassword"
                className={classes.inputValue}
                label="Password"
                type="password"
--- a/litmus-portal/frontend/src/pages/WorkflowDetails/styles.ts
+++ b/litmus-portal/frontend/src/pages/WorkflowDetails/styles.ts
@ -35,7 +35,7 @@ const useStyles = makeStyles((theme: Theme) => ({
    display: 'flex',
    flexDirection: 'column',
    padding: '0.5rem 0.5rem',
-    height: '68vh',
+    height: '100%',
    backgroundColor: theme.palette.cards.header,
  },

--- a/litmus-portal/frontend/src/views/ChaosWorkflows/BrowseSchedule/TableData.tsx
+++ b/litmus-portal/frontend/src/views/ChaosWorkflows/BrowseSchedule/TableData.tsx
@ -391,6 +391,7 @@ const TableData: React.FC<TableDataProps> = ({
            <></>
          )}
          {projectRole !== 'Viewer' &&
+            data.cronSyntax !== '' &&
            YAML.parse(data.workflow_manifest).spec.suspend !== true && (
              <MenuItem
                value="Disable"
--- a/litmus-portal/frontend/src/views/ChaosWorkflows/BrowseSchedule/index.tsx
+++ b/litmus-portal/frontend/src/views/ChaosWorkflows/BrowseSchedule/index.tsx
@ -242,9 +242,7 @@ const BrowseSchedule: React.FC = () => {
            color="primary"
            focused
          >
-            <InputLabel className={classes.selectText}>
-              Target Cluster
-            </InputLabel>
+            <InputLabel className={classes.selectText}>Target Agent</InputLabel>
            <Select
              value={filter.cluster}
              onChange={(event) =>
@ -312,7 +310,7 @@ const BrowseSchedule: React.FC = () => {
                {/* Cluster */}
                <TableCell>
                  <Typography className={classes.targetCluster}>
-                    {t('chaosWorkflows.browseSchedules.cluster')}
+                    {t('chaosWorkflows.browseSchedules.agent')}
                  </Typography>
                </TableCell>

--- a/litmus-portal/frontend/src/views/GetStarted/PasswordSet/index.tsx
+++ b/litmus-portal/frontend/src/views/GetStarted/PasswordSet/index.tsx
@ -62,6 +62,7 @@ const PasswordSet: React.FC<PasswordSetProps> = ({
      </div>
      <form id="login-form" className={classes.inputDiv}>
        <InputField
+          data-cy="inputPassword"
          className={classes.inputValue}
          label={t('getStarted.password.label')}
          type="password"
@ -77,6 +78,7 @@ const PasswordSet: React.FC<PasswordSetProps> = ({
          }}
        />
        <InputField
+          data-cy="confirmInputPassword"
          className={classes.inputValue}
          label={t('getStarted.password.cnfLabel')}
          type="password"
@ -96,14 +98,16 @@ const PasswordSet: React.FC<PasswordSetProps> = ({
          }
        />
        <div className={classes.buttonGroup}>
-          <ButtonFilled
-            className={classes.submitButton}
-            type="submit"
-            disabled={isError.current}
-            onClick={handleSubmit}
-          >
-            {t('getStarted.button.continue')}
-          </ButtonFilled>
+          <div data-cy="nextButton">
+            <ButtonFilled
+              className={classes.submitButton}
+              type="submit"
+              disabled={isError.current}
+              onClick={handleSubmit}
+            >
+              {t('getStarted.button.continue')}
+            </ButtonFilled>
+          </div>
          <Typography className={classes.step}>
            {t('getStarted.button.step')} {currentStep}{' '}
            {t('getStarted.button.of')} {totalStep}
--- a/litmus-portal/frontend/src/views/GetStarted/ProjectSet/index.tsx
+++ b/litmus-portal/frontend/src/views/GetStarted/ProjectSet/index.tsx
@ -145,6 +145,7 @@ const ProjectSet: React.FC<ProjectSetProps> = ({
        className={classes.inputDiv}
      >
        <InputField
+          data-cy="inputProjectName"
          className={classes.inputValue}
          label={t('getStarted.project.label')}
          value={projectName}
@ -160,17 +161,19 @@ const ProjectSet: React.FC<ProjectSetProps> = ({
          onChange={(e) => setProjectName(e.target.value)}
        />
        <div className={classes.buttonGroup}>
-          <ButtonFilled
-            type="submit"
-            className={classes.submitButton}
-            disabled={isError.current}
-          >
-            {isLoading ? (
-              <Loader size={loaderSize} />
-            ) : (
-              <Typography>{t('getStarted.button.letsStart')}</Typography>
-            )}
-          </ButtonFilled>
+          <div data-cy="startButton">
+            <ButtonFilled
+              type="submit"
+              className={classes.submitButton}
+              disabled={isError.current}
+            >
+              {isLoading ? (
+                <Loader size={loaderSize} />
+              ) : (
+                <Typography>{t('getStarted.button.letsStart')}</Typography>
+              )}
+            </ButtonFilled>
+          </div>
          <Typography className={classes.step}>
            {t('getStarted.button.step')} {currentStep}{' '}
            {t('getStarted.button.of')} {totalStep}
--- a/litmus-portal/frontend/src/views/WorkflowDetails/ArgoWorkflow/styles.ts
+++ b/litmus-portal/frontend/src/views/WorkflowDetails/ArgoWorkflow/styles.ts
@ -24,7 +24,7 @@ const useStyles = makeStyles((theme: Theme) => ({
  // Workflow Graph
  dagreGraph: {
    width: '100%',
-    height: '90%',
+    minHeight: '60vh',
    cursor: 'grab',

    // Styles for nodes
--- a/litmus-portal/frontend/src/views/WorkflowDetails/LogsModal/styles.ts
+++ b/litmus-portal/frontend/src/views/WorkflowDetails/LogsModal/styles.ts
@ -70,7 +70,7 @@ const useStyles = makeStyles((theme: Theme) => ({

  // Right side panel for Logs
  logsPanel: {
-    width: '100%',
+    width: '65%',
    textAlign: 'left',
    borderLeft: `1px solid ${theme.palette.border.main}`,
  },
--- a/litmus-portal/frontend/src/views/WorkflowDetails/LogsSwitcher/styles.ts
+++ b/litmus-portal/frontend/src/views/WorkflowDetails/LogsSwitcher/styles.ts
@ -6,7 +6,7 @@ const useStyles = makeStyles((theme: Theme) => ({
    [theme.breakpoints.up('lg')]: {
      height: '100%',
    },
-    height: '15rem',
+    height: '100%',
    background: theme.palette.cards.header,
    color: theme.palette.text.primary,
    textAlign: 'left',
--- a/litmus-portal/frontend/src/views/WorkflowDetails/WorkflowNodeInfo/styles.ts
+++ b/litmus-portal/frontend/src/views/WorkflowDetails/WorkflowNodeInfo/styles.ts
@ -2,7 +2,7 @@ import { makeStyles, Theme } from '@material-ui/core/styles';

 const useStyles = makeStyles((theme: Theme) => ({
  root: {
-    height: '25rem',
+    minHeight: '25rem',
    width: '100%',
    backgroundColor: theme.palette.cards.background,
    padding: theme.spacing(4, 6, 6, 6),