From cae657423442699d18ef660137024ff8e3068af1 Mon Sep 17 00:00:00 2001
From: Sayan Mondal <sayan@chaosnative.com>
Date: Thu, 8 Jul 2021 12:23:35 +0530
Subject: [PATCH] Adding data-cy for E2E and fixing Edit Scheduile View YAML
 (#2977)

Signed-off-by: Sayan Mondal <sayan@chaosnative.com>
---
 .../src/pages/EditSchedule/Schedule.tsx       |   2 +
 .../frontend/src/pages/EditSchedule/index.tsx | 290 ++++++++++--------
 .../frontend/src/pages/EditSchedule/styles.ts |  29 ++
 .../src/pages/WorkflowDetails/index.tsx       |   5 +-
 .../CreateWorkflow/ScheduleWorkflow/index.tsx |   1 +
 .../CreateWorkflow/TuneWorkflow/index.tsx     |   1 +
 .../CreateWorkflow/TuneWorkflow/styles.ts     |   1 -
 .../WorkflowDetails/LogsSwitcher/index.tsx    |   9 +-
 8 files changed, 213 insertions(+), 125 deletions(-)

diff --git a/litmus-portal/frontend/src/pages/EditSchedule/Schedule.tsx b/litmus-portal/frontend/src/pages/EditSchedule/Schedule.tsx
index 62edebac6..4e2e124fe 100644
--- a/litmus-portal/frontend/src/pages/EditSchedule/Schedule.tsx
+++ b/litmus-portal/frontend/src/pages/EditSchedule/Schedule.tsx
@@ -493,6 +493,7 @@ const ScheduleWorkflow = () => {
                     <div className={classes.innerRecurring}>
                       <FormControl component="fieldset">
                         <RadioGroup
+                          data-cy="RecurringSchedule"
                           aria-label="instanceDef"
                           name="instanceDef"
                           value={valueDef}
@@ -750,6 +751,7 @@ const ScheduleWorkflow = () => {
           Cancel
         </ButtonOutlined>
         <ButtonFilled
+          data-cy="VerifyButton"
           onClick={() =>
             history.push({
               pathname: `/workflows/schedule/${getProjectID()}/${fetchWorkflowNameFromManifest(
diff --git a/litmus-portal/frontend/src/pages/EditSchedule/index.tsx b/litmus-portal/frontend/src/pages/EditSchedule/index.tsx
index 39d86ab94..611c759fd 100644
--- a/litmus-portal/frontend/src/pages/EditSchedule/index.tsx
+++ b/litmus-portal/frontend/src/pages/EditSchedule/index.tsx
@@ -67,6 +67,7 @@ const EditSchedule: React.FC = () => {
     },
   ]);
 
+  const [yamlOpen, setYAMLOpen] = React.useState(false);
   const [open, setOpen] = React.useState(false);
   const [finishModalOpen, setFinishModalOpen] = useState(false);
   const [errorModal, setErrorModal] = useState(false);
@@ -204,7 +205,7 @@ const EditSchedule: React.FC = () => {
 
   const handleEditOpen = () => {
     setModified(false);
-    setOpen(true);
+    setYAMLOpen(true);
   };
 
   const handleEditClose = () => {
@@ -253,136 +254,180 @@ const EditSchedule: React.FC = () => {
           </Typography>
           <div className={classes.root}>
             <div className={classes.innerContainer}>
-              <Typography className={classes.sumText}>
-                {t('createWorkflow.verifyCommit.summary.header')}
-              </Typography>
-
-              <div className={classes.outerSum}>
-                <div className={classes.summaryDiv}>
-                  <div className={classes.innerSumDiv}>
-                    <Typography className={classes.col1}>
-                      {t('createWorkflow.verifyCommit.summary.workflowName')}:
-                    </Typography>
-                  </div>
-                  <div className={classes.col2} data-cy="WorkflowName">
-                    <Typography>
-                      {fetchWorkflowNameFromManifest(manifest)}
-                    </Typography>
-                  </div>
-                </div>
-
-                <div className={classes.summaryDiv}>
-                  <div className={classes.innerSumDiv}>
-                    <Typography className={classes.col1}>
-                      {t('createWorkflow.verifyCommit.summary.clustername')}:
-                    </Typography>
-                  </div>
-                  <Typography className={classes.schCol2}>
-                    {clustername}
-                  </Typography>
-                </div>
-
-                <div className={classes.summaryDiv}>
-                  <div className={classes.innerSumDiv}>
-                    <Typography className={classes.col1}>
-                      {t('createWorkflow.verifyCommit.summary.desc')}:
-                    </Typography>
-                  </div>
-                  <div className={classes.col2}>
-                    <Typography>{workflow.description}</Typography>
-                  </div>
-                </div>
-                <div className={classes.summaryDiv}>
-                  <div className={classes.innerSumDiv}>
-                    <Typography className={classes.col1}>
-                      {t('createWorkflow.verifyCommit.summary.schedule')}:
-                    </Typography>
-                  </div>
-                  <div className={classes.schCol2}>
-                    {cronSyntax === '' ? (
-                      <Typography>
-                        {t('createWorkflow.verifyCommit.summary.schedulingNow')}
+              {yamlOpen ? (
+                <div className={classes.editorWrapper}>
+                  <div className={`${classes.flex} ${classes.additional}`}>
+                    <div className={classes.flex}>
+                      <img
+                        style={{ width: '2rem' }}
+                        src="/icons/terminal.svg"
+                        alt="Terminal Icon"
+                      />
+                      <Typography className={classes.name}>
+                        {fetchWorkflowNameFromManifest(manifest)}.yaml
                       </Typography>
-                    ) : (
-                      <Typography>{cronstrue.toString(cronSyntax)}</Typography>
-                    )}
+                    </div>
 
                     <ButtonOutlined
-                      className={classes.editButton}
-                      onClick={() =>
-                        history.push({
-                          pathname: `/workflows/schedule/${projectID}/${fetchWorkflowNameFromManifest(
-                            manifest
-                          )}/set`,
-                          search: `?projectID=${projectID}&projectRole=${userRole}`,
-                        })
-                      }
+                      onClick={() => setYAMLOpen(false)}
+                      className={classes.editorCloseBtn}
                     >
-                      <EditIcon className={classes.editIcon} data-cy="edit" />
-                      {t('editSchedule.edit')}
+                      x
                     </ButtonOutlined>
                   </div>
+                  <YamlEditor
+                    content={manifest}
+                    filename={workflow.name}
+                    readOnly
+                  />
                 </div>
-                <div className={classes.summaryDiv}>
-                  <div className={classes.innerSumDiv}>
-                    <Typography className={classes.col1}>
-                      {t('createWorkflow.verifyCommit.summary.adjustedWeights')}
-                      :
-                    </Typography>
-                  </div>
-                  {weights.length === 0 ? (
-                    <div>
-                      <Typography className={classes.col2}>
-                        {t('createWorkflow.verifyCommit.error')}
-                      </Typography>
-                    </div>
-                  ) : (
-                    <div className={classes.adjWeights}>
-                      <div className={classes.progress}>
-                        {weights.map((Test) => (
-                          <AdjustedWeights
-                            key={Test.weight}
-                            testName={`${Test.experimentName} ${t(
-                              'createWorkflow.verifyCommit.test'
-                            )}`}
-                            testValue={Test.weight}
-                            spacing={false}
-                            icon={false}
-                          />
-                        ))}
+              ) : (
+                <>
+                  <Typography className={classes.sumText}>
+                    {t('createWorkflow.verifyCommit.summary.header')}
+                  </Typography>
+
+                  <div className={classes.outerSum}>
+                    <div className={classes.summaryDiv}>
+                      <div className={classes.innerSumDiv}>
+                        <Typography className={classes.col1}>
+                          {t(
+                            'createWorkflow.verifyCommit.summary.workflowName'
+                          )}
+                          :
+                        </Typography>
+                      </div>
+                      <div className={classes.col2} data-cy="WorkflowName">
+                        <Typography>
+                          {fetchWorkflowNameFromManifest(manifest)}
+                        </Typography>
                       </div>
                     </div>
-                  )}
-                </div>
-                <div className={classes.summaryDiv}>
-                  <div className={classes.innerSumDiv}>
-                    <Typography className={classes.col1}>
-                      {t('createWorkflow.verifyCommit.YAML')}
-                    </Typography>
-                  </div>
-                  <div className={classes.yamlFlex}>
-                    {weights.length === 0 ? (
-                      <Typography className={classes.spacingHorizontal}>
-                        {t('createWorkflow.verifyCommit.errYaml')}
+
+                    <div className={classes.summaryDiv}>
+                      <div className={classes.innerSumDiv}>
+                        <Typography className={classes.col1}>
+                          {t('createWorkflow.verifyCommit.summary.clustername')}
+                          :
+                        </Typography>
+                      </div>
+                      <Typography className={classes.schCol2}>
+                        {clustername}
                       </Typography>
-                    ) : (
-                      <Typography>
-                        <b>{yamlStatus}</b>
-                        <span className={classes.spacingHorizontal}>
-                          {t('createWorkflow.verifyCommit.youCanMoveOn')}
-                        </span>
-                      </Typography>
-                    )}
-                    <br />
-                    <ButtonFilled
-                      className={classes.verifyYAMLButton}
-                      onClick={handleEditOpen}
-                    >
-                      {t('createWorkflow.verifyCommit.button.viewYaml')}
-                    </ButtonFilled>
+                    </div>
+
+                    <div className={classes.summaryDiv}>
+                      <div className={classes.innerSumDiv}>
+                        <Typography className={classes.col1}>
+                          {t('createWorkflow.verifyCommit.summary.desc')}:
+                        </Typography>
+                      </div>
+                      <div className={classes.col2}>
+                        <Typography>{workflow.description}</Typography>
+                      </div>
+                    </div>
+                    <div className={classes.summaryDiv}>
+                      <div className={classes.innerSumDiv}>
+                        <Typography className={classes.col1}>
+                          {t('createWorkflow.verifyCommit.summary.schedule')}:
+                        </Typography>
+                      </div>
+                      <div className={classes.schCol2}>
+                        {cronSyntax === '' ? (
+                          <Typography>
+                            {t(
+                              'createWorkflow.verifyCommit.summary.schedulingNow'
+                            )}
+                          </Typography>
+                        ) : (
+                          <Typography>
+                            {cronstrue.toString(cronSyntax)}
+                          </Typography>
+                        )}
+
+                        <ButtonOutlined
+                          className={classes.editButton}
+                          onClick={() =>
+                            history.push({
+                              pathname: `/workflows/schedule/${projectID}/${fetchWorkflowNameFromManifest(
+                                manifest
+                              )}/set`,
+                              search: `?projectID=${projectID}&projectRole=${userRole}`,
+                            })
+                          }
+                        >
+                          <EditIcon
+                            className={classes.editIcon}
+                            data-cy="edit"
+                          />
+                          {t('editSchedule.edit')}
+                        </ButtonOutlined>
+                      </div>
+                    </div>
+                    <div className={classes.summaryDiv}>
+                      <div className={classes.innerSumDiv}>
+                        <Typography className={classes.col1}>
+                          {t(
+                            'createWorkflow.verifyCommit.summary.adjustedWeights'
+                          )}
+                          :
+                        </Typography>
+                      </div>
+                      {weights.length === 0 ? (
+                        <div>
+                          <Typography className={classes.col2}>
+                            {t('createWorkflow.verifyCommit.error')}
+                          </Typography>
+                        </div>
+                      ) : (
+                        <div className={classes.adjWeights}>
+                          <div className={classes.progress}>
+                            {weights.map((Test) => (
+                              <AdjustedWeights
+                                key={Test.weight}
+                                testName={`${Test.experimentName} ${t(
+                                  'createWorkflow.verifyCommit.test'
+                                )}`}
+                                testValue={Test.weight}
+                                spacing={false}
+                                icon={false}
+                              />
+                            ))}
+                          </div>
+                        </div>
+                      )}
+                    </div>
+                    <div className={classes.summaryDiv}>
+                      <div className={classes.innerSumDiv}>
+                        <Typography className={classes.col1}>
+                          {t('createWorkflow.verifyCommit.YAML')}
+                        </Typography>
+                      </div>
+                      <div className={classes.yamlFlex}>
+                        {weights.length === 0 ? (
+                          <Typography className={classes.spacingHorizontal}>
+                            {t('createWorkflow.verifyCommit.errYaml')}
+                          </Typography>
+                        ) : (
+                          <Typography>
+                            <b>{yamlStatus}</b>
+                            <span className={classes.spacingHorizontal}>
+                              {t('createWorkflow.verifyCommit.youCanMoveOn')}
+                            </span>
+                          </Typography>
+                        )}
+                        <br />
+                        <ButtonFilled
+                          className={classes.verifyYAMLButton}
+                          onClick={handleEditOpen}
+                        >
+                          {t('createWorkflow.verifyCommit.button.viewYaml')}
+                        </ButtonFilled>
+                      </div>
+                    </div>
                   </div>
-                </div>
-              </div>
+                </>
+              )}
             </div>
           </div>
           {/* Cancel and Save Button */}
@@ -397,7 +442,10 @@ const EditSchedule: React.FC = () => {
             >
               {t('editSchedule.cancel')}
             </ButtonOutlined>
-            <ButtonFilled onClick={() => handleNext()}>
+            <ButtonFilled
+              data-cy="SaveEditScheduleButton"
+              onClick={() => handleNext()}
+            >
               {t('editSchedule.save')}
             </ButtonFilled>
           </div>
diff --git a/litmus-portal/frontend/src/pages/EditSchedule/styles.ts b/litmus-portal/frontend/src/pages/EditSchedule/styles.ts
index 054cf57b0..94543d499 100644
--- a/litmus-portal/frontend/src/pages/EditSchedule/styles.ts
+++ b/litmus-portal/frontend/src/pages/EditSchedule/styles.ts
@@ -227,4 +227,33 @@ export const useStyles = makeStyles((theme: Theme) => ({
     fontWeight: 'bold',
     margin: theme.spacing(2, 0),
   },
+
+  // Editor
+  editorWrapper: {
+    marginBottom: theme.spacing(-4),
+  },
+  flex: {
+    display: 'flex',
+  },
+  additional: {
+    width: '95%',
+    margin: '0rem auto',
+    justifyContent: 'space-between',
+  },
+  name: {
+    margin: theme.spacing(1, 0, 2, 2),
+    fontWeight: 'bold',
+  },
+  editorTopBtn: {
+    padding: '0.4rem',
+    fontSize: '0.8rem',
+  },
+  editorCloseBtn: {
+    width: '0.5rem',
+    borderColor: theme.palette.disabledBackground,
+    color: theme.palette.text.disabled,
+    minWidth: '2rem',
+    padding: '0.2rem',
+    fontSize: '1rem',
+  },
 }));
diff --git a/litmus-portal/frontend/src/pages/WorkflowDetails/index.tsx b/litmus-portal/frontend/src/pages/WorkflowDetails/index.tsx
index f8e52ef27..01e0110c5 100644
--- a/litmus-portal/frontend/src/pages/WorkflowDetails/index.tsx
+++ b/litmus-portal/frontend/src/pages/WorkflowDetails/index.tsx
@@ -204,7 +204,10 @@ const WorkflowDetails: React.FC = () => {
               </Tabs>
             </AppBar>
             <TabPanel value={workflowDetailsTabValue} index={0}>
-              <div className={classes.graphView}>
+              <div
+                className={classes.graphView}
+                data-cy="dagreGraphWorkflowLevel"
+              >
                 {/* Argo Workflow DAG Graph */}
                 <ArgoWorkflow
                   nodes={
diff --git a/litmus-portal/frontend/src/views/CreateWorkflow/ScheduleWorkflow/index.tsx b/litmus-portal/frontend/src/views/CreateWorkflow/ScheduleWorkflow/index.tsx
index 49c9a59c4..976d70f7b 100644
--- a/litmus-portal/frontend/src/views/CreateWorkflow/ScheduleWorkflow/index.tsx
+++ b/litmus-portal/frontend/src/views/CreateWorkflow/ScheduleWorkflow/index.tsx
@@ -471,6 +471,7 @@ const ScheduleWorkflow = forwardRef((_, ref) => {
                   <div className={classes.innerRecurring}>
                     <FormControl component="fieldset">
                       <RadioGroup
+                        data-cy="RecurringSchedule"
                         aria-label="instanceDef"
                         name="instanceDef"
                         value={valueDef}
diff --git a/litmus-portal/frontend/src/views/CreateWorkflow/TuneWorkflow/index.tsx b/litmus-portal/frontend/src/views/CreateWorkflow/TuneWorkflow/index.tsx
index 47cdcc349..21e31e651 100644
--- a/litmus-portal/frontend/src/views/CreateWorkflow/TuneWorkflow/index.tsx
+++ b/litmus-portal/frontend/src/views/CreateWorkflow/TuneWorkflow/index.tsx
@@ -795,6 +795,7 @@ const TuneWorkflow = forwardRef((_, ref) => {
             {/* Edit Button */}
             {manifest !== '' && (
               <ButtonOutlined
+                data-cy="EditSequenceButton"
                 disabled={isVisualizationComplete}
                 onClick={() => setEditSequence(true)}
               >
diff --git a/litmus-portal/frontend/src/views/CreateWorkflow/TuneWorkflow/styles.ts b/litmus-portal/frontend/src/views/CreateWorkflow/TuneWorkflow/styles.ts
index 1008c321c..a3eb92f61 100644
--- a/litmus-portal/frontend/src/views/CreateWorkflow/TuneWorkflow/styles.ts
+++ b/litmus-portal/frontend/src/views/CreateWorkflow/TuneWorkflow/styles.ts
@@ -82,7 +82,6 @@ const useStyles = makeStyles((theme) => ({
 
   // Table
   table: {
-    minWidth: '40rem',
     minHeight: '23rem',
   },
   revertChaos: {
diff --git a/litmus-portal/frontend/src/views/WorkflowDetails/LogsSwitcher/index.tsx b/litmus-portal/frontend/src/views/WorkflowDetails/LogsSwitcher/index.tsx
index afedff914..e7205025a 100644
--- a/litmus-portal/frontend/src/views/WorkflowDetails/LogsSwitcher/index.tsx
+++ b/litmus-portal/frontend/src/views/WorkflowDetails/LogsSwitcher/index.tsx
@@ -159,7 +159,7 @@ const LogsSwitcher: React.FC<LogsSwitcherProps> = ({
     try {
       const podLogs = JSON.parse(logs);
       return (
-        <div>
+        <div data-cy="LogsWindow">
           <div>
             {workflow !== undefined &&
             JSON.parse(workflow?.execution_data).nodes[pod_name].type ===
@@ -245,7 +245,12 @@ const LogsSwitcher: React.FC<LogsSwitcherProps> = ({
         <TabPanel value={selectedTab} index={1} style={{ height: '100%' }}>
           <div className={classes.logs}>
             <div style={{ whiteSpace: 'pre-wrap' }}>
-              <Typography className={classes.text}>{chaosResult}</Typography>
+              <Typography
+                data-cy="ChaosResultTypography"
+                className={classes.text}
+              >
+                {chaosResult}
+              </Typography>
             </div>
           </div>
         </TabPanel>