nodejs
/
corepack
mirror of https://github.com/nodejs/corepack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: disable `v8-compile-cache` when using `npm@>=9.7.0` (#276) 

Node.js segfaults when using `npm@>=9.7.0` and `v8-compile-cache`
```console
$ docker run -it node:20.3.0-slim corepack npm@9.7.1 --version
[SIGSEGV]
```
This commit is contained in:
Kristoffer K 2023-06-13 11:35:21 +02:00 committed by GitHub
parent 17d1f3dd41
commit 2f3678cd79
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
sources/corepackUtils.ts
View File

@ -169,7 +169,7 @@ export async function installVersion(installTarget: string, locator: Locator, {s
/**
* Loads the binary, taking control of the current process.
*/
export async function runVersion(installSpec: { location: string, spec: PackageManagerSpec }, binName: string, args: Array<string>): Promise<void> {
export async function runVersion(locator: Locator, installSpec: { location: string, spec: PackageManagerSpec }, binName: string, args: Array<string>): Promise<void> {
let binPath: string | null = null;
if (Array.isArray(installSpec.spec.bin)) {
if (installSpec.spec.bin.some(bin => bin === binName)) {
@ -191,8 +191,12 @@ export async function runVersion(installSpec: { location: string, spec: PackageM
if (!binPath)
throw new Error(`Assertion failed: Unable to locate path for bin '${binName}'`);
// @ts-expect-error - No types
await import(`v8-compile-cache`);
// Node.js segfaults when using npm@>=9.7.0 and v8-compile-cache
// $ docker run -it node:20.3.0-slim corepack npm@9.7.1 --version
// [SIGSEGV]
if (locator.name !== `npm` || semver.lt(locator.reference, `9.7.0`))
// @ts-expect-error - No types
await import(`v8-compile-cache`);
// We load the binary into the current process,
// while making it think it was spawned.

2
sources/main.ts
View File

@ -85,7 +85,7 @@ async function executePackageManagerRequest({packageManager, binaryName, binaryV
const installSpec = await context.engine.ensurePackageManager(resolved);
return await corepackUtils.runVersion(installSpec, binaryName, args);
return await corepackUtils.runVersion(resolved, installSpec, binaryName, args);
}
export async function runMain(argv: Array<string>) {