From 1c65c4ed3785432fe9e9fa71a26799d86df10de4 Mon Sep 17 00:00:00 2001 From: Christopher Horrell Date: Mon, 19 Sep 2016 16:36:04 -0400 Subject: [PATCH] Set ENV for NODE_ENV This ensures that the value of NODE_ENV is made available to the CMD context. This ensures commands such as `npm start` or `node index.js` are using the correct NODE_ENV. See comments in https://github.com/docker-library/official-images/pull/2156 --- 0.10/onbuild/Dockerfile | 1 + 0.12/onbuild/Dockerfile | 1 + 4.5/onbuild/Dockerfile | 1 + 6.6/onbuild/Dockerfile | 1 + Dockerfile-onbuild.template | 1 + 5 files changed, 5 insertions(+) diff --git a/0.10/onbuild/Dockerfile b/0.10/onbuild/Dockerfile index e65ee50f..2fb1ffce 100644 --- a/0.10/onbuild/Dockerfile +++ b/0.10/onbuild/Dockerfile @@ -4,6 +4,7 @@ RUN mkdir -p /usr/src/app WORKDIR /usr/src/app ONBUILD ARG NODE_ENV +ONBUILD ENV NODE_ENV $NODE_ENV ONBUILD COPY package.json /usr/src/app/ ONBUILD RUN npm install ONBUILD COPY . /usr/src/app diff --git a/0.12/onbuild/Dockerfile b/0.12/onbuild/Dockerfile index 23e3889c..63bc0a1a 100644 --- a/0.12/onbuild/Dockerfile +++ b/0.12/onbuild/Dockerfile @@ -4,6 +4,7 @@ RUN mkdir -p /usr/src/app WORKDIR /usr/src/app ONBUILD ARG NODE_ENV +ONBUILD ENV NODE_ENV $NODE_ENV ONBUILD COPY package.json /usr/src/app/ ONBUILD RUN npm install ONBUILD COPY . /usr/src/app diff --git a/4.5/onbuild/Dockerfile b/4.5/onbuild/Dockerfile index 18447aed..ce1c341c 100644 --- a/4.5/onbuild/Dockerfile +++ b/4.5/onbuild/Dockerfile @@ -4,6 +4,7 @@ RUN mkdir -p /usr/src/app WORKDIR /usr/src/app ONBUILD ARG NODE_ENV +ONBUILD ENV NODE_ENV $NODE_ENV ONBUILD COPY package.json /usr/src/app/ ONBUILD RUN npm install ONBUILD COPY . /usr/src/app diff --git a/6.6/onbuild/Dockerfile b/6.6/onbuild/Dockerfile index 8e9ef43a..a782172e 100644 --- a/6.6/onbuild/Dockerfile +++ b/6.6/onbuild/Dockerfile @@ -4,6 +4,7 @@ RUN mkdir -p /usr/src/app WORKDIR /usr/src/app ONBUILD ARG NODE_ENV +ONBUILD ENV NODE_ENV $NODE_ENV ONBUILD COPY package.json /usr/src/app/ ONBUILD RUN npm install ONBUILD COPY . /usr/src/app diff --git a/Dockerfile-onbuild.template b/Dockerfile-onbuild.template index bce95f9f..78613998 100644 --- a/Dockerfile-onbuild.template +++ b/Dockerfile-onbuild.template @@ -4,6 +4,7 @@ RUN mkdir -p /usr/src/app WORKDIR /usr/src/app ONBUILD ARG NODE_ENV +ONBUILD ENV NODE_ENV $NODE_ENV ONBUILD COPY package.json /usr/src/app/ ONBUILD RUN npm install ONBUILD COPY . /usr/src/app