nodejs
/
docker-node
mirror of https://github.com/nodejs/docker-node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Shellcheck: SC2181 Check exit code directly

This commit is contained in:
Nick Schonning 2017-06-14 02:45:21 -04:00
parent 5380d0fffa
commit 359ba16fe0
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test-build.sh
View File

@ -31,9 +31,8 @@ for version in "${versions[@]}"; do
tag=$(cat $version/Dockerfile | grep "ENV NODE_VERSION" | cut -d' ' -f3) tag=$(cat $version/Dockerfile | grep "ENV NODE_VERSION" | cut -d' ' -f3)
info "Building $tag..." info "Building $tag..."
docker build -t node:$tag $version
if [[ $? -gt 0 ]]; then if ! docker build -t node:$tag $version; then
fatal "Build of $tag failed!" fatal "Build of $tag failed!"
else else
info "Build of $tag succeeded." info "Build of $tag succeeded."
@ -53,9 +52,8 @@ for version in "${versions[@]}"; do
[ -f "$version/$variant/Dockerfile" ] || continue [ -f "$version/$variant/Dockerfile" ] || continue
info "Building $tag-$variant variant..." info "Building $tag-$variant variant..."
docker build -t node:$tag-$variant $version/$variant
if [[ $? -gt 0 ]]; then if ! docker build -t node:$tag-$variant $version/$variant; then
fatal "Build of $tag-$variant failed!" fatal "Build of $tag-$variant failed!"
else else
info "Build of $tag-$variant succeeded." info "Build of $tag-$variant succeeded."