Commit Graph

46 Commits

Author SHA1 Message Date
Jana Rangasamy 47b3109686 docs: added punctuation 2024-03-30 13:43:02 +05:30
Laurent Goderre c7cf5c2910
Merge pull request #1771 from zsolt-dev/zsolt-dev-patch-1
Add an example of how to create smaller images without npm/yarn
2023-10-18 16:44:31 -04:00
Florian Mutter 30e942efc9
Add `--init` to `docker run` example
Make example `docker run` command follow best practice described in section `## Handling Kernel Signals`
2023-03-08 11:28:50 +01:00
Zsolt Szabo 647fbaa404
Refactor example in best practices 2022-09-28 14:26:00 +02:00
Zsolt Szabo ebc9c19382
Update example config in best practices
- add workdir
- use chown on copy for smaller image
- create a variable for alpine version instead of explaining in a comment
2022-09-17 15:04:38 +02:00
Zsolt Szabo 0c3d9de40c
Merge two commands in example dockerfile 2022-09-16 17:16:51 +02:00
Zsolt Szabo 999efab646
Update best practices table of Contents 2022-09-16 14:23:22 +02:00
Zsolt Szabo 9025d87163
Add an example of a smaller alpine image without npm/yarn 2022-09-16 14:07:58 +02:00
Jeff Mealo 1c1c0001a7
Update BestPractices.md
Link to PoLP to clarify why root should be avoided in a container
2022-01-06 14:59:22 -05:00
Nick Schonning 8a750d61c4
docs: Update instructions for python 3 2021-11-07 20:12:38 -05:00
Nick Schonning 747216238b fix: DocToc in Bestpractices.md
Add control statements and re-run generation
2020-11-02 10:58:56 -05:00
Ted Stoychev 1705b4a658
Added 'Upgrading/downgrading Yarn' to ToC 2019-10-14 17:17:56 +03:00
Khaled Bentoumi e18668a03f Update Upgrading/downgrading Yarn best practice 2019-10-09 09:58:57 -04:00
Xiao Liang 5510c50a0b
docs(BestPractices.md/Handling Kernel Signals): fix
`CTRL-C` sends `SIGINT` signal, not `SIGTERM`.
2019-08-29 01:06:07 +08:00
Zadkiel 52f1580722
fix: remove use of virtual in node-gyp multistage 2019-05-01 20:22:02 +02:00
Michael Salaverry bfb02b9ff6
additional typo fix
realized there was another minor typo apline should be alpine
2018-12-18 15:22:47 +02:00
Michael Salaverry 617a31de36 documentation: fix typo in recommended multistage Dockerfile (#958) 2018-12-18 14:15:39 +01:00
Daniel Cohen 7db40ed097 Adds documentation for using node-gyp in alpine release (#907) 2018-12-02 10:05:18 +01:00
Joseph C. Sible 99023fb878 explain how to upgrade Yarn on Alpine (#902)
Fixes #901
2018-11-09 08:09:11 +10:00
jeff-nz abee44757f update doc for alpine del node group and add user assign group (#871)
fixes #870
2018-10-10 23:48:11 +02:00
Peter Dave Hello e788c21cd5 Improve markdown syntax/style [ci skip] 2018-08-02 03:04:17 +08:00
Peter Dave Hello bbf199c459 Fix format issues 2018-05-15 20:05:37 +08:00
Janeene Beeforth 3c44288786 Update "Upgrading/downgrading Yarn" guide in BestPractices doc (#708)
Update documentation on installing a custom yarn version to specify that the /usr/local/bin/yarn* links need updating.
2018-04-30 12:23:03 +02:00
Eyal Zekaria 926d446701
Update README.md
with an example on how to upgrade/downgrade yarn version
2018-03-09 11:41:09 +01:00
Heechul Ryu c689df6ab1 Add an instruction for adding PATH for global modules (#624) 2018-02-07 09:12:11 +01:00
Christian Klaussner f7ea65ca68 Fix typo in "Non-root User" section (#612) 2018-01-14 14:35:55 +01:00
Mark Tinsley 68dcfbef53 tiny word fix (#561)
"you" => "your"
2017-10-31 07:40:08 +01:00
Matthias Klan 078ff84cb7 Update BestPractices.md (#552)
* Update BestPractices.md

missing ENV keyword

* Update BestPractices.md

add Dockerfile highlighting for global npm dependencies section
2017-10-20 08:03:17 +02:00
Selwyn 8b83c9d9c6 Add exit signal handling benefit to CMD section (#551) 2017-10-19 17:07:58 +02:00
Laurent Goderre e53b1ca725 Added a section about global npm install
Closes #505
2017-10-06 08:10:14 -04:00
Florian Bellazouz dbab8eb181 update docs/BestPractices.md - typo (#500)
* update docs/BestPractices.md - typo

* update docs/BestPractices.md - UpperCase Tini
2017-08-14 10:33:54 +02:00
Codruț Constantin Gușoi c3694d8baa Adds instructions for modifying the `node` user (#328)
Also highlights the `Best Practices` section in the `README.md` file so
the new instructions are easier to find.

Special thanks to:
* @blueimp for the uid/gid change command
* @LaurentGoderre for the user rename command

Refs #289
2017-07-25 15:45:47 +02:00
Florian Traber 1efc018dad fix: init flag is included in docker only after 1.13 not 1.3
see https://docs.docker.com/release-notes/docker-engine/#1130-2017-01-18
2017-07-11 09:13:44 +02:00
Peter Petrov bc7cd93b73 Update BestPractices.md 2017-05-18 17:10:52 +03:00
Peter Dave Hello f5113b03be Add "Table of Contents" in README and docs 2017-05-04 00:02:07 +08:00
Steven 9228dbd5b1 Update BestPractices.md to remove alpine user
Since the `node` user was added to the alpine variant, there is no need to recommend that they need to create the `node` user. In fact, it would break. Only the `onbuild` variant does not have the user.

I also added the `USER node` syntax to show how to [set the user](https://docs.docker.com/engine/reference/builder/#user) in the dockerfile.
2017-04-20 09:09:57 -04:00
William Blankenship 5e45e63704 Document init wrapper
Closes #323
2017-02-02 16:19:52 -05:00
Steven 7183790a18 Change user from `app` to `node` for consistency 2016-12-28 14:30:04 -05:00
Steven 26ba1103c1 Update BestPractices.md with alpine user
Added entry to **Non-root User** section to show adding user & group in the alpine variant since the commands are a little different.
2016-12-28 14:22:26 -05:00
Tim Brust 5feca06d21 docs: fix best-practices memory heading level 2016-12-21 14:10:12 +01:00
Christopher Horrell 87b641c1f3 Merge pull request #270 from davidbarton/patch-2
In docs example use home dir as work dir
2016-11-23 05:53:41 -08:00
David Barton 70b9081d18 In docs example change home dir for work dir
I think user home dir works better instead of `-w "/usr/src/app"` use `-w "/home/node/app"`
2016-11-15 13:53:11 +01:00
David Barton e0cf6e2d24 Wrong username mentioned in docs
`app` should be `node`
2016-11-15 13:49:11 +01:00
Laurent Goderre 435636ab11 Updated the non-root section of the Best Practices 2016-11-07 10:02:54 -05:00
Steven 6c64e29389 docs: Fix minor typos in BestPractices.md
Add commas and change "inn" to "in".
2016-07-07 12:04:50 -04:00
William Blankenship 0e0c74ad89 Create BestPractices.md
Best Practices
2016-03-16 16:56:58 -04:00