nodejs
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

events: fix event-target enumerable keys 

PR-URL: https://github.com/nodejs/node/pull/33616
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit is contained in:
Benjamin Gruenbaum 2020-05-28 18:08:31 +03:00 committed by Ruben Bridgewater
parent 56e44601d2
commit 2d071e767d
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/internal/event_target.js
View File

@ -51,6 +51,13 @@ class Event {
this.#bubbles = !!bubbles;
this.#composed = !!composed;
this.#type = String(type);
// isTrusted is special (LegacyUnforgeable)
Object.defineProperty(this, 'isTrusted', {
get() { return false; },
set(ignoredValue) { return false; },
enumerable: true,
configurable: false
});
}
[customInspectSymbol](depth, options) {
@ -99,7 +106,6 @@ class Event {
get returnValue() { return !this.defaultPrevented; }
get bubbles() { return this.#bubbles; }
get composed() { return this.#composed; }
get isTrusted() { return false; }
get eventPhase() {
return this[kTarget] ? 2 : 0; // Equivalent to AT_TARGET or NONE
}

5
test/parallel/test-eventtarget.js
View File

@ -50,7 +50,10 @@ ok(EventTarget);
ev.preventDefault();
strictEqual(ev.defaultPrevented, true);
}
{
const ev = new Event('foo');
deepStrictEqual(Object.keys(ev), ['isTrusted']);
}
{
const eventTarget = new EventTarget();