nodejs
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix flaky test-repl-sigint-nested-eval 

There is a race condition where process.kill can be sent before the
target is ready to receive the signal.

Fixes: https://github.com/nodejs/node/issues/41123
PR-URL: https://github.com/nodejs/node/pull/45354
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This commit is contained in:
Rich Trott 2022-11-12 18:56:08 -08:00 committed by GitHub
parent 4ac830effd
commit 6a22b77bba
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/parallel/parallel.status
View File

@ -5,8 +5,6 @@ prefix parallel
# sample-test : PASS,FLAKY
[true] # This section applies to all platforms
# https://github.com/nodejs/node/issues/41123
test-repl-sigint-nested-eval: PASS, FLAKY
# https://github.com/nodejs/node/issues/43084
test-worker-http2-stream-terminate: PASS, FLAKY

13
test/parallel/test-repl-sigint-nested-eval.js
View File

@ -10,9 +10,8 @@ if (!common.isMainThread)
const assert = require('assert');
const spawn = require('child_process').spawn;
process.env.REPL_TEST_PPID = process.pid;
const child = spawn(process.execPath, [ '-i' ], {
stdio: [null, null, 2]
stdio: [null, null, 2, 'ipc']
});
let stdout = '';
@ -22,7 +21,8 @@ child.stdout.on('data', function(c) {
});
child.stdout.once('data', common.mustCall(() => {
process.on('SIGUSR2', common.mustCall(() => {
child.on('message', common.mustCall((msg) => {
assert.strictEqual(msg, 'repl is busy');
process.kill(child.pid, 'SIGINT');
child.stdout.once('data', common.mustCall(() => {
// Make sure REPL still works.
@ -30,9 +30,10 @@ child.stdout.once('data', common.mustCall(() => {
}));
}));
child.stdin.write('process.kill(+process.env.REPL_TEST_PPID, "SIGUSR2");' +
'vm.runInThisContext("while(true){}", ' +
'{ breakOnSigint: true });\n');
child.stdin.write(
'vm.runInThisContext("process.send(\'repl is busy\'); while(true){}", ' +
'{ breakOnSigint: true });\n'
);
}));
child.on('close', function(code) {