nodejs
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: make SIGPROF message a real warning 

This commit replaces a fprintf() with a call to
ProcessEmitWarning().

Refs: https://github.com/nodejs/node/issues/12706
PR-URL: https://github.com/nodejs/node/pull/12709
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit is contained in:
cjihrig 2017-04-27 18:26:17 -04:00
parent 9ce2271e81
commit b6001a2da5
2 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/signal_wrap.cc
View File

@ -92,7 +92,8 @@ class SignalWrap : public HandleWrap {
if (signum == SIGPROF) {
Environment* env = Environment::GetCurrent(args);
if (env->inspector_agent()->IsStarted()) {
fprintf(stderr, "process.on(SIGPROF) is reserved while debugging\n");
ProcessEmitWarning(env,
"process.on(SIGPROF) is reserved while debugging");
return;
}
}

17
test/parallel/test-warn-sigprof.js Normal file
View File

@ -0,0 +1,17 @@
'use strict';
const common = require('../common');
// The inspector attempts to start when Node starts. Once started, the inspector
// warns on the use of a SIGPROF listener.
common.skipIfInspectorDisabled();
if (common.isWindows) {
common.skip('test does not apply to Windows');
return;
}
common.expectWarning('Warning',
'process.on(SIGPROF) is reserved while debugging');
process.on('SIGPROF', () => {});