nodejs
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: cleanup vars to const and '==' to '===' 

Modified test-http-upgrade-client.js

Line 29: Changed var port to const port
Line 30: Changed var headers to const headers
Line 57: Changed assert.equal to assert.strictEqual
Line 61: Changed var expectedHeaders to const
Line 69: Changed '==' to '===' comparison

PR-URL: https://github.com/nodejs/node/pull/8705
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
This commit is contained in:
oogz 2016-09-21 14:56:10 -07:00 committed by Ilkka Myller
parent 92c1d9622b
commit c063502566
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/parallel/test-http-upgrade-client.js
View File

@ -26,8 +26,8 @@ var srv = net.createServer(function(c) {
});
srv.listen(0, '127.0.0.1', common.mustCall(function() {
var port = this.address().port;
var headers = [
const port = this.address().port;
const headers = [
{
connection: 'upgrade',
upgrade: 'websocket'
@ -54,11 +54,11 @@ srv.listen(0, '127.0.0.1', common.mustCall(function() {
});
socket.on('close', common.mustCall(function() {
assert.equal(recvData, 'nurtzo');
assert.strictEqual(recvData.toString(), 'nurtzo');
}));
console.log(res.headers);
var expectedHeaders = {
const expectedHeaders = {
hello: 'world',
connection: 'upgrade',
upgrade: 'websocket'
@ -66,7 +66,7 @@ srv.listen(0, '127.0.0.1', common.mustCall(function() {
assert.deepStrictEqual(expectedHeaders, res.headers);
socket.end();
if (--left == 0)
if (--left === 0)
srv.close();
}));
req.on('close', common.mustCall(function() {