Rename "Dynamic Property" to "Getter/Setter" in sys.inspect.

This commit is contained in:
Tim Caswell 2010-01-03 14:04:35 -06:00 committed by Ryan Dahl
parent 6c68a9679b
commit fd184ee2fa
2 changed files with 6 additions and 6 deletions

View File

@ -101,13 +101,13 @@ var formatter = function(value, indent, parents) {
var child;
if (value.__lookupGetter__(x)) {
if (value.__lookupSetter__(x)) {
child = "[Dynamic Property]";
child = "[Getter/Setter]";
} else {
child = "[Dynamic Property Read-only]";
child = "[Getter]";
}
} else {
if (value.__lookupSetter__(x)) {
child = "[Dynamic Property Write-only]";
child = "[Setter]";
} else {
child = f(value[x]);
}

View File

@ -26,8 +26,8 @@ assert.equal('{\n "a": {\n "b": 2\n }\n}', inspect({'a': {'b': 2}}));
// Dynamic properties
assert.equal(
"{\n \"readonly\": [Dynamic Property Read-only],\n \"readwrite\": [Dynamic Property],\n \"writeonly\": [Dynamic Property Write-only]\n}",
inspect({get readonly() {return 1;},get readwrite(){return 2;},set readwrite(value){},set writeonly(val){}})
"{\n \"readonly\": [Getter],\n \"readwrite\": [Getter/Setter],\n \"writeonly\": [Setter]\n}",
inspect({get readonly(){},get readwrite(){},set readwrite(val){},set writeonly(val){}})
);
var value = {};
@ -41,6 +41,6 @@ assert.equal('{\n "0": 1,\n "length": 1\n}', inspect(value));
value = [1,2,3];
value.__defineGetter__('growingLength', function () { this.push(true); return this.length; });
assert.equal(
"{\n \"0\": 1,\n \"1\": 2,\n \"2\": 3,\n \"growingLength\": [Dynamic Property Read-only]\n}",
"{\n \"0\": 1,\n \"1\": 2,\n \"2\": 3,\n \"growingLength\": [Getter]\n}",
inspect(value)
);