3 Commits

Author	SHA1	Message	Date
Chengzhong Wu	3b90f3454d	node-api: add nested object wrap and napi_ref test ... Test that an napi_ref can be nested inside another ObjectWrap. The test shows a critical case where a finalizer deletes an `napi_ref` whose finalizer is also scheduled. PR-URL: https://github.com/nodejs/node/pull/57981 Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com> Reviewed-By: Michael Dawson <midawson@redhat.com>	2025-04-25 22:22:30 +00:00
tannal	0b6b2a4dc7	test: merge ongc and gcutil into gc.js ... PR-URL: https://github.com/nodejs/node/pull/54355 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>	2024-08-29 08:49:52 +01:00
legendecas	f14fa1bbca	node-api: generalize finalizer second pass callback ... Generalize the finalizer's second pass callback to make it cancellable and simplify the code around the second pass callback. With this change, it is determined that Reference::Finalize or RefBase::Finalize are called once, either from the env's shutdown, or from the env's second pass callback. All existing node-api js tests should pass without a touch. The js_native_api cctest is no longer applicable with this change, just removing it. PR-URL: https://github.com/nodejs/node/pull/44141 Refs: https://github.com/nodejs/node/issues/44071 Reviewed-By: Michael Dawson <midawson@redhat.com>	2022-12-20 01:44:42 +08:00