3 Commits

Author	SHA1	Message	Date
Richard Lau	abd73d865a	build: fix compatibility with V8's `depot_tools` ... Recent changes to `depot_tools`'s `ninja.py` proxy is causing infinite recursion in our V8 CI builds as we checkout `depot_tools` into a directory with a leading `_` (i.e. `_depot_tools`) and the proxy now checks for an exact match (i.e. `== "depot_tools"`) instead of `endswith("depot_tools")`. Rename our checkout to `depot_tools` (without the leading `_`) so the `ninja.py` proxy can exclude it when reinvoking `ninja`. PR-URL: https://github.com/nodejs/node/pull/57330 Fixes: https://github.com/nodejs/build/issues/4027 Refs: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6259139 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com>	2025-03-07 15:35:36 +00:00
Richard Lau	6a1316dc99	tools: run fetch_deps.py with Python 3 ... Python 3 is now required to run `gclient`. Run `tools/v8/fetch_deps.py`, which spawns `glient`, with Python 3. PR-URL: https://github.com/nodejs/node/pull/48729 Fixes: https://github.com/nodejs/node/issues/48728 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>	2023-07-12 14:40:57 +00:00
Michaël Zasso	d45e0ebd4d	tools: take ownership of deps/v8/tools/node ... The files are not maintained nor used upstream anymore. PR-URL: https://github.com/nodejs/node/pull/39222 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>	2021-07-06 01:40:54 +00:00