nodejs
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
37,669 Commits 57 Branches 891 Tags 1.9 GiB
Commit Graph

5 Commits

Author SHA1 Message Date
Luigi Pinca 1dcba68534 test: fix argument order in assertion 
The first argument is the actual value, the second argument is the
expected value.

PR-URL: https://github.com/nodejs/node/pull/40842
Fixes: https://github.com/nodejs/node/issues/40277
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
 2021-11-21 14:14:23 +00:00
Luigi Pinca 4873870c54 test: deflake http2-pipe-named-pipe 
Wait for all data to be read before sending the response and closing
the client.

Fixes: https://github.com/nodejs/node/issues/40277

PR-URL: https://github.com/nodejs/node/pull/40842
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
 2021-11-21 14:14:22 +00:00
Luigi Pinca 2a8576dfa5 test: use descriptive name for destination file 
`http2-url-tests.js` is misleading. Use the same name of the source file
instead.

PR-URL: https://github.com/nodejs/node/pull/40842
Fixes: https://github.com/nodejs/node/issues/40277
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
 2021-11-21 14:14:21 +00:00
Joyee Cheung 1357913180
test: use URL fixtures under test/fixtures/wpt/url/resources 
Removes the following files:

- test/fixtures/url-tests.js
- test/fixtures/url-setter-tests.js
- test/fixtures/url-toascii.js

in favor of:

- test/fixtures/wpt/url/resources/urltestdata.json
- test/fixtures/wpt/url/resources/setters_tests.json
- test/fixtures/wpt/url/resources/toascii.json

Also removes dependency of `fixtures/url-tests.js` in http2 tests
and use `fixtures/person-large.jpg` instead since they are just
looking for a big enough file to transfer.

PR-URL: https://github.com/nodejs/node/pull/24035
Refs: https://github.com/nodejs/node/issues/23192
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
 2018-11-09 20:27:20 +08:00
Anna Henningsen 64a3fadf71
src: remove StreamBase::kFlagHasWritev 
Since libuv 1.21.0, pipes on Windows support `writev` on the
libuv side.

This allows for some simplification, and makes the `StreamBase`
API more uniform (multi-buffer `Write()` is always supported now,
including when used by other non-JS consumers like HTTP/2).

PR-URL: https://github.com/nodejs/node/pull/21527
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2018-06-30 15:52:54 +02:00