diff --git a/lib/src/main/java/javasdk/FlagEvaluationDetails.java b/lib/src/main/java/javasdk/FlagEvaluationDetails.java index 4f70567b..b7367ad4 100644 --- a/lib/src/main/java/javasdk/FlagEvaluationDetails.java +++ b/lib/src/main/java/javasdk/FlagEvaluationDetails.java @@ -8,16 +8,14 @@ import javax.annotation.Nullable; @Data @Builder public class FlagEvaluationDetails implements BaseEvaluation { String flagKey; - HookEvaluation executedHooks; T value; @Nullable String variant; Reason reason; @Nullable ErrorCode errorCode; - public static FlagEvaluationDetails from(ProviderEvaluation providerEval, String flagKey, HookEvaluation executedHooks) { + public static FlagEvaluationDetails from(ProviderEvaluation providerEval, String flagKey) { return FlagEvaluationDetails.builder() .flagKey(flagKey) - .executedHooks(executedHooks) .value(providerEval.getValue()) .variant(providerEval.getVariant()) .reason(providerEval.getReason()) diff --git a/lib/src/main/java/javasdk/HookEvaluation.java b/lib/src/main/java/javasdk/HookEvaluation.java deleted file mode 100644 index 0edb0b1b..00000000 --- a/lib/src/main/java/javasdk/HookEvaluation.java +++ /dev/null @@ -1,27 +0,0 @@ -package javasdk; - -import lombok.Data; - -import java.util.ArrayList; -import java.util.List; - -@Data -public class HookEvaluation { - private List> before = new ArrayList<>(); - private List> after = new ArrayList<>(); - private List> error = new ArrayList<>(); - private List> afterAll = new ArrayList<>(); - - public void addBefore(Hook h) { - before.add(h); - } - public void addAfter(Hook h) { - after.add(h); - } - public void addError(Hook h) { - error.add(h); - } - public void addAfterAll(Hook h) { - afterAll.add(h); - } -} diff --git a/lib/src/main/java/javasdk/OpenFeatureClient.java b/lib/src/main/java/javasdk/OpenFeatureClient.java index a0cd0448..147b7a25 100644 --- a/lib/src/main/java/javasdk/OpenFeatureClient.java +++ b/lib/src/main/java/javasdk/OpenFeatureClient.java @@ -67,7 +67,7 @@ public class OpenFeatureClient implements Client { throw new GeneralError("Unknown flag type"); } - details = FlagEvaluationDetails.from(providerEval, key, null); + details = FlagEvaluationDetails.from(providerEval, key); this.afterHooks(hookCtx, details, mergedHooks, hints); } catch (Exception e) { log.error("Unable to correctly evaluate flag with key {} due to exception {}", key, e.getMessage());