diff --git a/lib/src/main/java/dev/openfeature/javasdk/FlagEvaluationLifecycle.java b/lib/src/main/java/dev/openfeature/javasdk/FlagEvaluationLifecycle.java index 61c0b0f5..ee5bce40 100644 --- a/lib/src/main/java/dev/openfeature/javasdk/FlagEvaluationLifecycle.java +++ b/lib/src/main/java/dev/openfeature/javasdk/FlagEvaluationLifecycle.java @@ -3,6 +3,6 @@ package dev.openfeature.javasdk; import java.util.List; public interface FlagEvaluationLifecycle { - void registerHooks(Hook... hooks); + void addHooks(Hook... hooks); List getClientHooks(); } diff --git a/lib/src/main/java/dev/openfeature/javasdk/OpenFeatureAPI.java b/lib/src/main/java/dev/openfeature/javasdk/OpenFeatureAPI.java index a70c4285..8ff53d66 100644 --- a/lib/src/main/java/dev/openfeature/javasdk/OpenFeatureAPI.java +++ b/lib/src/main/java/dev/openfeature/javasdk/OpenFeatureAPI.java @@ -38,7 +38,7 @@ public class OpenFeatureAPI { return new OpenFeatureClient(this, name, version); } - public void registerHooks(Hook... hooks) { + public void addHooks(Hook... hooks) { this.apiHooks.addAll(Arrays.asList(hooks)); } diff --git a/lib/src/main/java/dev/openfeature/javasdk/OpenFeatureClient.java b/lib/src/main/java/dev/openfeature/javasdk/OpenFeatureClient.java index 238b714f..ba04e967 100644 --- a/lib/src/main/java/dev/openfeature/javasdk/OpenFeatureClient.java +++ b/lib/src/main/java/dev/openfeature/javasdk/OpenFeatureClient.java @@ -29,7 +29,7 @@ public class OpenFeatureClient implements Client { } @Override - public void registerHooks(Hook... hooks) { + public void addHooks(Hook... hooks) { this.clientHooks.addAll(Arrays.asList(hooks)); } diff --git a/lib/src/test/java/dev/openfeature/javasdk/DeveloperExperienceTest.java b/lib/src/test/java/dev/openfeature/javasdk/DeveloperExperienceTest.java index f103843b..690fa77d 100644 --- a/lib/src/test/java/dev/openfeature/javasdk/DeveloperExperienceTest.java +++ b/lib/src/test/java/dev/openfeature/javasdk/DeveloperExperienceTest.java @@ -27,7 +27,7 @@ class DeveloperExperienceTest { OpenFeatureAPI api = OpenFeatureAPI.getInstance(); api.setProvider(new NoOpProvider()); Client client = api.getClient(); - client.registerHooks(exampleHook); + client.addHooks(exampleHook); Boolean retval = client.getBooleanValue(flagKey, false); verify(exampleHook, times(1)).finallyAfter(any(), any()); assertFalse(retval); @@ -40,7 +40,7 @@ class DeveloperExperienceTest { OpenFeatureAPI api = OpenFeatureAPI.getInstance(); api.setProvider(new NoOpProvider()); Client client = api.getClient(); - client.registerHooks(clientHook); + client.addHooks(clientHook); Boolean retval = client.getBooleanValue(flagKey, false, null, FlagEvaluationOptions.builder().hook(evalHook).build()); verify(clientHook, times(1)).finallyAfter(any(), any()); diff --git a/lib/src/test/java/dev/openfeature/javasdk/FlagEvaluationSpecTests.java b/lib/src/test/java/dev/openfeature/javasdk/FlagEvaluationSpecTests.java index 641af25c..1eb09348 100644 --- a/lib/src/test/java/dev/openfeature/javasdk/FlagEvaluationSpecTests.java +++ b/lib/src/test/java/dev/openfeature/javasdk/FlagEvaluationSpecTests.java @@ -42,12 +42,12 @@ public class FlagEvaluationSpecTests { Hook h1 = mock(Hook.class); Hook h2 = mock(Hook.class); OpenFeatureAPI api = OpenFeatureAPI.getInstance(); - api.registerHooks(h1); + api.addHooks(h1); assertEquals(1, api.getApiHooks().size()); assertEquals(h1, api.getApiHooks().get(0)); - api.registerHooks(h2); + api.addHooks(h2); assertEquals(2, api.getApiHooks().size()); assertEquals(h2, api.getApiHooks().get(1)); } @@ -67,8 +67,8 @@ public class FlagEvaluationSpecTests { Client c = _client(); Hook m1 = mock(Hook.class); Hook m2 = mock(Hook.class); - c.registerHooks(m1); - c.registerHooks(m2); + c.addHooks(m1); + c.addHooks(m2); List hooks = c.getClientHooks(); assertEquals(2, hooks.size()); assertTrue(hooks.contains(m1)); @@ -142,7 +142,7 @@ public class FlagEvaluationSpecTests { Client c = _client(); Hook clientHook = mock(Hook.class); Hook invocationHook = mock(Hook.class); - c.registerHooks(clientHook); + c.addHooks(clientHook); c.getBooleanValue("key", false, null, FlagEvaluationOptions.builder() .hook(invocationHook) .build()); diff --git a/lib/src/test/java/dev/openfeature/javasdk/HookSpecTests.java b/lib/src/test/java/dev/openfeature/javasdk/HookSpecTests.java index 65e1293a..ee6daee8 100644 --- a/lib/src/test/java/dev/openfeature/javasdk/HookSpecTests.java +++ b/lib/src/test/java/dev/openfeature/javasdk/HookSpecTests.java @@ -195,7 +195,7 @@ public class HookSpecTests { List evalOrder = new ArrayList(); OpenFeatureAPI api = OpenFeatureAPI.getInstance(); api.setProvider(new NoOpProvider()); - api.registerHooks(new Hook() { + api.addHooks(new Hook() { @Override public Optional before(HookContext ctx, ImmutableMap hints) { evalOrder.add("api before"); @@ -220,7 +220,7 @@ public class HookSpecTests { }); Client c = api.getClient(); - c.registerHooks(new Hook() { + c.addHooks(new Hook() { @Override public Optional before(HookContext ctx, ImmutableMap hints) { evalOrder.add("client before");