open-feature
/
java-sdk
mirror of https://github.com/open-feature/java-sdk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: Implement equals for the ImmutableMetadata object (#512)

This commit is contained in:
Thomas Poignant 2023-07-17 16:52:00 +02:00 committed by GitHub
parent bbb4008b38
commit 6253aee3b3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/java/dev/openfeature/sdk/ImmutableMetadata.java
View File

@ -1,5 +1,6 @@
package dev.openfeature.sdk; package dev.openfeature.sdk;
import lombok.EqualsAndHashCode;
import lombok.extern.slf4j.Slf4j; import lombok.extern.slf4j.Slf4j;
import java.util.HashMap; import java.util.HashMap;
@ -10,6 +11,7 @@ import java.util.Map;
* through builder and accessors. * through builder and accessors.
*/ */
@Slf4j @Slf4j
@EqualsAndHashCode
public class ImmutableMetadata { public class ImmutableMetadata {
private final Map<String, Object> metadata; private final Map<String, Object> metadata;

22
src/test/java/dev/openfeature/sdk/FlagEvaluationDetailsTest.java
View File

@ -45,4 +45,26 @@ class FlagEvaluationDetailsTest {
assertEquals(errorMessage, details.getErrorMessage()); assertEquals(errorMessage, details.getErrorMessage());
assertEquals(metadata, details.getFlagMetadata()); assertEquals(metadata, details.getFlagMetadata());
} }
@Test
@DisplayName("should be able to compare 2 FlagEvaluationDetails")
public void compareFlagEvaluationDetails(){
FlagEvaluationDetails fed1 = FlagEvaluationDetails.builder()
.reason(Reason.ERROR.toString())
.value(false)
.errorCode(ErrorCode.GENERAL)
.errorMessage("error XXX")
.flagMetadata(ImmutableMetadata.builder().addString("metadata","1").build())
.build();
FlagEvaluationDetails fed2 = FlagEvaluationDetails.builder()
.reason(Reason.ERROR.toString())
.value(false)
.errorCode(ErrorCode.GENERAL)
.errorMessage("error XXX")
.flagMetadata(ImmutableMetadata.builder().addString("metadata","1").build())
.build();
assertEquals(fed1,fed2);
}
} }