refactor!: Change the package name. Everyone knows it's java (or it doesn't matter) (#111)

* Change the package name. Everyone knows it's java (or it doesn't matter)

Fixes #82

Signed-off-by: Justin Abrahms <justin@abrah.ms>

* Missed 2 strings

Signed-off-by: Justin Abrahms <justin@abrah.ms>

* remove broken flagd import until changes absorbed

Signed-off-by: Todd Baert <toddbaert@gmail.com>

Signed-off-by: Justin Abrahms <justin@abrah.ms>
Signed-off-by: Todd Baert <toddbaert@gmail.com>
Co-authored-by: Todd Baert <toddbaert@gmail.com>
This commit is contained in:
Justin Abrahms 2022-10-05 11:46:04 -07:00 committed by GitHub
parent 715fd032cf
commit 6eeeddd2ea
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
59 changed files with 96 additions and 105 deletions

View File

@ -1,7 +1,7 @@
# OpenFeature SDK for Java
[![Maven Central](https://maven-badges.herokuapp.com/maven-central/dev.openfeature/javasdk/badge.svg)](https://maven-badges.herokuapp.com/maven-central/dev.openfeature/javasdk)
[![javadoc](https://javadoc.io/badge2/dev.openfeature/javasdk/javadoc.svg)](https://javadoc.io/doc/dev.openfeature/javasdk)
[![Maven Central](https://maven-badges.herokuapp.com/maven-central/dev.openfeature/sdk/badge.svg)](https://maven-badges.herokuapp.com/maven-central/dev.openfeature/sdk)
[![javadoc](https://javadoc.io/badge2/dev.openfeature/sdk/javadoc.svg)](https://javadoc.io/doc/dev.openfeature/sdk)
[![Project Status: WIP Initial development is in progress, but there has not yet been a stable, usable release suitable for the public.](https://www.repostatus.org/badges/latest/wip.svg)](https://www.repostatus.org/#wip)
[![Specification](https://img.shields.io/static/v1?label=Specification&message=v0.5.0&color=yellow)](https://github.com/open-feature/spec/tree/v0.5.0)
[![Known Vulnerabilities](https://snyk.io/test/github/open-feature/java-sdk/badge.svg)](https://snyk.io/test/github/open-feature/java-sdk)
@ -20,7 +20,7 @@ This library is intended to be used in server-side contexts and has not been eva
While `Boolean` provides the simplest introduction, we offer a variety of flag types.
```java
import dev.openfeature.javasdk.Structure;
import dev.openfeature.sdk.Structure;
class MyClass {
public UI booleanExample() {
@ -65,7 +65,7 @@ class MyClass {
```xml
<dependency>
<groupId>dev.openfeature</groupId>
<artifactId>javasdk</artifactId>
<artifactId>sdk</artifactId>
<version>0.2.2</version>
</dependency>
```
@ -90,7 +90,7 @@ If you would like snapshot builds, this is the relevant repository information:
<!-- x-release-please-start-version -->
```groovy
dependencies {
implementation 'dev.openfeature:javasdk:0.2.2'
implementation 'dev.openfeature:sdk:0.2.2'
}
```
<!-- x-release-please-end-version -->

13
pom.xml
View File

@ -3,7 +3,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>dev.openfeature</groupId>
<artifactId>javasdk</artifactId>
<artifactId>sdk</artifactId>
<version>0.2.2</version> <!--x-release-please-version -->
<properties>
@ -137,15 +137,6 @@
<version>31.1-jre</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>dev.openfeature.contrib.providers</groupId>
<artifactId>flagd</artifactId>
<!-- TODO: update this version -->
<version>0.3.2</version>
<scope>test</scope>
</dependency>
</dependencies>
<dependencyManagement>
@ -271,7 +262,7 @@
<configuration>
<dataFile>${project.build.directory}/coverage-reports/jacoco-ut.exec</dataFile>
<excludes>
<exclude>dev/openfeature/javasdk/exceptions/**</exclude>
<exclude>dev/openfeature/sdk/exceptions/**</exclude>
</excludes>
<rules>

View File

@ -2,7 +2,7 @@
"bootstrap-sha": "c701a6c4ebbe1170a25ca7636a31508b9628831c",
"packages": {
".": {
"package-name": "dev.openfeature.javasdk",
"package-name": "dev.openfeature.sdk",
"release-type": "simple",
"bump-minor-pre-major": true,
"bump-patch-for-minor-pre-major": true,
@ -13,4 +13,4 @@
]
}
}
}
}

View File

@ -6,18 +6,18 @@
<!-- I'm reasonably confident that the singleton pattern isn't exposing internal representation -->
<And>
<Class name="dev.openfeature.javasdk.OpenFeatureAPI"/>
<Class name="dev.openfeature.sdk.OpenFeatureAPI"/>
<Bug pattern="MS_EXPOSE_REP"/>
</And>
<!-- similarly, client using the singleton doesn't seem bad -->
<And>
<Class name="dev.openfeature.javasdk.OpenFeatureClient"/>
<Class name="dev.openfeature.sdk.OpenFeatureClient"/>
<Bug pattern="EI_EXPOSE_REP2"/>
</And>
<!-- Test class that should be excluded -->
<Match>
<Class name="dev.openfeature.javasdk.DoSomethingProvider"/>
<Class name="dev.openfeature.sdk.DoSomethingProvider"/>
</Match>
<!-- All bugs in test classes, except for JUnit-specific bugs -->
<Match>

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
/**
* This is a common interface between the evaluation results that providers return and what is given to the end users.

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
public interface BooleanHook extends Hook<Boolean> {

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
import java.util.List;

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
public interface DoubleHook extends Hook<Double> {

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
public enum ErrorCode {
PROVIDER_NOT_READY, FLAG_NOT_FOUND, PARSE_ERROR, TYPE_MISMATCH, TARGETING_KEY_MISSING, INVALID_CONTEXT, GENERAL

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
import java.time.Instant;
import java.util.List;

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
import java.util.ArrayList;
import java.util.List;

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
/**
* An API for the type-specific fetch methods offered to users.

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
import lombok.Builder;
import lombok.Data;

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
import java.util.HashMap;
import java.util.List;

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
public enum FlagValueType {
STRING, INTEGER, DOUBLE, OBJECT, BOOLEAN;

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
import java.util.Map;
import java.util.Optional;

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
import lombok.Builder;
import lombok.NonNull;

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
import java.util.*;
import java.util.function.Consumer;

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
public interface IntegerHook extends Hook<Integer> {

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
/**
* Holds identifying information about a given entity.

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
import lombok.Getter;

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
import lombok.Getter;
import lombok.Setter;

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
import java.util.ArrayList;
import java.util.Arrays;
@ -6,9 +6,9 @@ import java.util.Collections;
import java.util.List;
import java.util.Map;
import dev.openfeature.javasdk.exceptions.GeneralError;
import dev.openfeature.javasdk.exceptions.OpenFeatureError;
import dev.openfeature.javasdk.internal.ObjectUtils;
import dev.openfeature.sdk.exceptions.GeneralError;
import dev.openfeature.sdk.exceptions.OpenFeatureError;
import dev.openfeature.sdk.internal.ObjectUtils;
import lombok.Getter;
import lombok.Setter;
import lombok.extern.slf4j.Slf4j;

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
import lombok.Builder;
import lombok.Data;

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
public enum Reason {
DISABLED, SPLIT, TARGETING_MATCH, DEFAULT, UNKNOWN, ERROR

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
public interface StringHook extends Hook<String> {

View File

@ -1,10 +1,10 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
import java.time.Instant;
import java.util.*;
import java.util.stream.Collectors;
import dev.openfeature.javasdk.exceptions.ValueNotConvertableError;
import dev.openfeature.sdk.exceptions.ValueNotConvertableError;
import lombok.EqualsAndHashCode;
import lombok.ToString;

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
import java.time.Instant;
import java.util.List;

View File

@ -1,6 +1,6 @@
package dev.openfeature.javasdk.exceptions;
package dev.openfeature.sdk.exceptions;
import dev.openfeature.javasdk.ErrorCode;
import dev.openfeature.sdk.ErrorCode;
import lombok.Getter;
import lombok.experimental.StandardException;

View File

@ -1,6 +1,6 @@
package dev.openfeature.javasdk.exceptions;
package dev.openfeature.sdk.exceptions;
import dev.openfeature.javasdk.ErrorCode;
import dev.openfeature.sdk.ErrorCode;
import lombok.Getter;
import lombok.experimental.StandardException;

View File

@ -1,6 +1,6 @@
package dev.openfeature.javasdk.exceptions;
package dev.openfeature.sdk.exceptions;
import dev.openfeature.javasdk.ErrorCode;
import dev.openfeature.sdk.ErrorCode;
import lombok.Getter;
import lombok.experimental.StandardException;

View File

@ -1,6 +1,6 @@
package dev.openfeature.javasdk.exceptions;
package dev.openfeature.sdk.exceptions;
import dev.openfeature.javasdk.ErrorCode;
import dev.openfeature.sdk.ErrorCode;
import lombok.experimental.StandardException;
@StandardException

View File

@ -1,6 +1,6 @@
package dev.openfeature.javasdk.exceptions;
package dev.openfeature.sdk.exceptions;
import dev.openfeature.javasdk.ErrorCode;
import dev.openfeature.sdk.ErrorCode;
import lombok.Getter;
import lombok.experimental.StandardException;

View File

@ -1,6 +1,6 @@
package dev.openfeature.javasdk.exceptions;
package dev.openfeature.sdk.exceptions;
import dev.openfeature.javasdk.ErrorCode;
import dev.openfeature.sdk.ErrorCode;
import lombok.Getter;
import lombok.experimental.StandardException;

View File

@ -1,6 +1,6 @@
package dev.openfeature.javasdk.exceptions;
package dev.openfeature.sdk.exceptions;
import dev.openfeature.javasdk.ErrorCode;
import dev.openfeature.sdk.ErrorCode;
import lombok.Getter;
import lombok.experimental.StandardException;

View File

@ -1,6 +1,6 @@
package dev.openfeature.javasdk.exceptions;
package dev.openfeature.sdk.exceptions;
import dev.openfeature.javasdk.ErrorCode;
import dev.openfeature.sdk.ErrorCode;
import lombok.Getter;
import lombok.experimental.StandardException;

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk.internal;
package dev.openfeature.sdk.internal;
import java.util.*;
import java.util.function.Supplier;

View File

@ -1,6 +1,6 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
import dev.openfeature.javasdk.exceptions.FlagNotFoundError;
import dev.openfeature.sdk.exceptions.FlagNotFoundError;
public class AlwaysBrokenProvider implements FeatureProvider {

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
@ -8,7 +8,7 @@ import static org.mockito.Mockito.verify;
import org.junit.jupiter.api.Test;
import dev.openfeature.javasdk.fixtures.HookFixtures;
import dev.openfeature.sdk.fixtures.HookFixtures;
import java.util.Arrays;

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
public class DoSomethingProvider implements FeatureProvider {

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
import static org.junit.jupiter.api.Assertions.assertEquals;

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.jupiter.api.Assertions.assertEquals;
@ -16,7 +16,7 @@ import java.util.List;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Test;
import dev.openfeature.javasdk.fixtures.HookFixtures;
import dev.openfeature.sdk.fixtures.HookFixtures;
import uk.org.lidalia.slf4jtest.LoggingEvent;
import uk.org.lidalia.slf4jtest.TestLogger;
import uk.org.lidalia.slf4jtest.TestLoggerFactory;

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
import org.junit.jupiter.api.Test;

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
import static org.assertj.core.api.Assertions.assertThatCode;
import static org.assertj.core.api.Assertions.fail;
@ -26,7 +26,7 @@ import org.junit.jupiter.api.Test;
import org.mockito.ArgumentCaptor;
import org.mockito.InOrder;
import dev.openfeature.javasdk.fixtures.HookFixtures;
import dev.openfeature.sdk.fixtures.HookFixtures;
import lombok.SneakyThrows;
public class HookSpecTest implements HookFixtures {

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.ArgumentMatchers.any;
@ -14,7 +14,7 @@ import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.EnumSource;
import dev.openfeature.javasdk.fixtures.HookFixtures;
import dev.openfeature.sdk.fixtures.HookFixtures;
class HookSupportTest implements HookFixtures {

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
import org.junit.jupiter.api.Test;

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
import static org.junit.jupiter.api.Assertions.assertEquals;

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
public class NotImplementedException extends RuntimeException {

View File

@ -1,8 +1,8 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
import java.util.*;
import dev.openfeature.javasdk.fixtures.HookFixtures;
import dev.openfeature.sdk.fixtures.HookFixtures;
import org.junit.jupiter.api.*;
import uk.org.lidalia.slf4jext.Level;
import uk.org.lidalia.slf4jtest.*;

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertNull;

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
import java.lang.annotation.Repeatable;

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
public @interface Specifications {
Specification[] value();

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotSame;

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
public class TestConstants {
public static final String BROKEN_MESSAGE = "This is borked.";

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk;
package dev.openfeature.sdk;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertThrows;

View File

@ -1,6 +1,6 @@
package dev.openfeature.javasdk.fixtures;
package dev.openfeature.sdk.fixtures;
import dev.openfeature.javasdk.*;
import dev.openfeature.sdk.*;
import static org.mockito.Mockito.spy;

View File

@ -1,4 +1,4 @@
package dev.openfeature.javasdk.integration;
package dev.openfeature.sdk.integration;
import org.junit.platform.suite.api.ConfigurationParameter;
import org.junit.platform.suite.api.IncludeEngines;

View File

@ -1,16 +1,16 @@
package dev.openfeature.javasdk.integration;
package dev.openfeature.sdk.integration;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;
import dev.openfeature.contrib.providers.flagd.FlagdProvider;
import dev.openfeature.javasdk.Client;
import dev.openfeature.javasdk.EvaluationContext;
import dev.openfeature.javasdk.FlagEvaluationDetails;
import dev.openfeature.javasdk.OpenFeatureAPI;
import dev.openfeature.javasdk.Reason;
import dev.openfeature.javasdk.Structure;
import dev.openfeature.javasdk.Value;
// import dev.openfeature.contrib.providers.flagd.FlagdProvider;
import dev.openfeature.sdk.Client;
import dev.openfeature.sdk.EvaluationContext;
import dev.openfeature.sdk.FlagEvaluationDetails;
import dev.openfeature.sdk.OpenFeatureAPI;
import dev.openfeature.sdk.Reason;
import dev.openfeature.sdk.Structure;
import dev.openfeature.sdk.Value;
import io.cucumber.java.BeforeAll;
import io.cucumber.java.en.Then;
import io.cucumber.java.en.When;
@ -44,7 +44,7 @@ public class StepDefinitions {
@BeforeAll()
public static void setup() {
OpenFeatureAPI.getInstance().setProvider(new FlagdProvider());
// OpenFeatureAPI.getInstance().setProvider(new FlagdProvider());
client = OpenFeatureAPI.getInstance().getClient();
}

View File

@ -1,10 +1,10 @@
package dev.openfeature.javasdk.internal;
package dev.openfeature.sdk.internal;
import java.util.*;
import org.junit.jupiter.api.*;
import static dev.openfeature.javasdk.internal.ObjectUtils.defaultIfNull;
import static dev.openfeature.sdk.internal.ObjectUtils.defaultIfNull;
import static org.assertj.core.api.Assertions.assertThat;
class ObjectUtilsTest {