open-feature
/
java-sdk
mirror of https://github.com/open-feature/java-sdk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

addresses PMD issues

This commit is contained in:
lopitz 2022-06-20 22:00:37 +02:00
parent b65718fc5a
commit bf1fc154fc
No known key found for this signature in database
GPG Key ID: 23EE7A36B9A92B2B
2 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/src/main/java/dev/openfeature/javasdk/HookSupport.java
View File

@ -8,27 +8,24 @@ import com.google.common.collect.Lists;
import lombok.RequiredArgsConstructor; import lombok.RequiredArgsConstructor;
import org.slf4j.Logger; import org.slf4j.Logger;
@SuppressWarnings({"unchecked", "rawtypes", "PMD.LoggerIsNotStaticFinal"})
@RequiredArgsConstructor @RequiredArgsConstructor
class HookSupport { class HookSupport {
private final Logger log; private final Logger log;
@SuppressWarnings({"unchecked", "rawtypes"})
public void errorHooks(FlagValueType flagValueType, HookContext hookCtx, Exception e, List<Hook> hooks, Map<String, Object> hints) { public void errorHooks(FlagValueType flagValueType, HookContext hookCtx, Exception e, List<Hook> hooks, Map<String, Object> hints) {
executeHooks(flagValueType, hooks, "error", hook -> hook.error(hookCtx, e, hints)); executeHooks(flagValueType, hooks, "error", hook -> hook.error(hookCtx, e, hints));
} }
@SuppressWarnings({"unchecked", "rawtypes"})
public void afterAllHooks(FlagValueType flagValueType, HookContext hookCtx, List<Hook> hooks, Map<String, Object> hints) { public void afterAllHooks(FlagValueType flagValueType, HookContext hookCtx, List<Hook> hooks, Map<String, Object> hints) {
executeHooks(flagValueType, hooks, "finally", hook -> hook.finallyAfter(hookCtx, hints)); executeHooks(flagValueType, hooks, "finally", hook -> hook.finallyAfter(hookCtx, hints));
} }
@SuppressWarnings({"unchecked", "rawtypes"})
public void afterHooks(FlagValueType flagValueType, HookContext hookContext, FlagEvaluationDetails details, List<Hook> hooks, Map<String, Object> hints) { public void afterHooks(FlagValueType flagValueType, HookContext hookContext, FlagEvaluationDetails details, List<Hook> hooks, Map<String, Object> hints) {
executeHooksUnchecked(flagValueType, hooks, hook -> hook.after(hookContext, details, hints)); executeHooksUnchecked(flagValueType, hooks, hook -> hook.after(hookContext, details, hints));
} }
@SuppressWarnings({"unchecked", "rawtypes"})
private <T> void executeHooks( private <T> void executeHooks(
FlagValueType flagValueType, List<Hook> hooks, FlagValueType flagValueType, List<Hook> hooks,
String hookMethod, String hookMethod,
@ -40,7 +37,6 @@ class HookSupport {
.forEach(hook -> executeChecked(hook, hookCode, hookMethod)); .forEach(hook -> executeChecked(hook, hookCode, hookMethod));
} }
@SuppressWarnings("rawtypes")
private <T> void executeHooksUnchecked( private <T> void executeHooksUnchecked(
FlagValueType flagValueType, List<Hook> hooks, FlagValueType flagValueType, List<Hook> hooks,
Consumer<Hook<T>> hookCode Consumer<Hook<T>> hookCode
@ -59,13 +55,11 @@ class HookSupport {
} }
} }
@SuppressWarnings("rawtypes")
public EvaluationContext beforeHooks(FlagValueType flagValueType, HookContext hookCtx, List<Hook> hooks, Map<String, Object> hints) { public EvaluationContext beforeHooks(FlagValueType flagValueType, HookContext hookCtx, List<Hook> hooks, Map<String, Object> hints) {
var result = callBeforeHooks(flagValueType, hookCtx, hooks, hints); var result = callBeforeHooks(flagValueType, hookCtx, hooks, hints);
return EvaluationContext.merge(hookCtx.getCtx(), collectContexts(result)); return EvaluationContext.merge(hookCtx.getCtx(), collectContexts(result));
} }
@SuppressWarnings({"unchecked", "rawtypes"})
private Stream<EvaluationContext> callBeforeHooks(FlagValueType flagValueType, HookContext hookCtx, List<Hook> hooks, Map<String, Object> hints) { private Stream<EvaluationContext> callBeforeHooks(FlagValueType flagValueType, HookContext hookCtx, List<Hook> hooks, Map<String, Object> hints) {
// These traverse backwards from normal. // These traverse backwards from normal.
return Lists return Lists

2
lib/src/main/java/dev/openfeature/javasdk/OpenFeatureClient.java
View File

@ -7,7 +7,7 @@ import dev.openfeature.javasdk.internal.ObjectUtils;
import lombok.Getter; import lombok.Getter;
import org.slf4j.*; import org.slf4j.*;
@SuppressWarnings({"PMD.DataflowAnomalyAnalysis", "unchecked", "rawtypes"}) @SuppressWarnings({"PMD.DataflowAnomalyAnalysis", "PMD.BeanMembersShouldSerialize", "unchecked", "rawtypes"})
public class OpenFeatureClient implements Client { public class OpenFeatureClient implements Client {
private static final Logger log = LoggerFactory.getLogger(OpenFeatureClient.class); private static final Logger log = LoggerFactory.getLogger(OpenFeatureClient.class);