open-feature
/
java-sdk
mirror of https://github.com/open-feature/java-sdk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Tests which validate the backend providers are actually called. 

Fixes #10
This commit is contained in:
Justin Abrahms 2022-05-27 21:10:50 -07:00
parent 3594044d05
commit c56b3901e2
No known key found for this signature in database
GPG Key ID: 599E2E12011DC474
2 changed files with 42 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/src/main/java/dev/openfeature/javasdk/OpenFeatureClient.java
View File

@ -65,6 +65,10 @@ public class OpenFeatureClient implements Client {
if (type == FlagValueType.BOOLEAN) {
// TODO: Can we guarantee that defaultValue is a boolean? If not, how to we handle that?
providerEval = (ProviderEvaluation<T>) provider.getBooleanEvaluation(key, (Boolean) defaultValue, invocationContext, options);
} else if(type == FlagValueType.STRING) {
providerEval = (ProviderEvaluation<T>) provider.getStringEvaluation(key, (String) defaultValue, invocationContext, options);
} else if (type == FlagValueType.INTEGER) {
providerEval = (ProviderEvaluation<T>) provider.getIntegerEvaluation(key, (Integer) defaultValue, invocationContext, options);
} else {
// TODO: Support other flag types.
throw new GeneralError("Unknown flag type");

48
lib/src/test/java/dev/openfeature/javasdk/FlagEvaluationSpecTests.java
View File

@ -81,20 +81,48 @@ public class FlagEvaluationSpecTests {
@Specification(spec="flag evaluation", number="1.8.1",text="The client MUST provide methods for typed flag " +
"evaluation, including boolean, numeric, string, and structure.")
@Test void value_flags() {
Client c = _client();
OpenFeatureAPI api = OpenFeatureAPI.getInstance();
api.setProvider(new FeatureProvider() {
@Override
public String getName() {
return "test";
}
@Override
public ProviderEvaluation<Boolean> getBooleanEvaluation(String key, Boolean defaultValue, EvaluationContext ctx, FlagEvaluationOptions options) {
return ProviderEvaluation.<Boolean>builder()
.value(!defaultValue).build();
}
@Override
public ProviderEvaluation<String> getStringEvaluation(String key, String defaultValue, EvaluationContext ctx, FlagEvaluationOptions options) {
return ProviderEvaluation.<String>builder()
.value(new StringBuilder(defaultValue).reverse().toString())
.build();
}
@Override
public ProviderEvaluation<Integer> getIntegerEvaluation(String key, Integer defaultValue, EvaluationContext ctx, FlagEvaluationOptions options) {
return ProviderEvaluation.<Integer>builder()
.value(defaultValue * 100)
.build();
}
});
Client c = api.getClient();
String key = "key";
assertFalse(c.getBooleanValue(key, false));
assertFalse(c.getBooleanValue(key, false, new EvaluationContext()));
assertFalse(c.getBooleanValue(key, false, new EvaluationContext(), FlagEvaluationOptions.builder().build()));
assertEquals(true, c.getBooleanValue(key, false));
assertEquals(true, c.getBooleanValue(key, false, new EvaluationContext()));
assertEquals(true, c.getBooleanValue(key, false, new EvaluationContext(), FlagEvaluationOptions.builder().build()));
assertEquals("my-string", c.getStringValue(key, "my-string"));
assertEquals("my-string", c.getStringValue(key, "my-string", new EvaluationContext()));
assertEquals("my-string", c.getStringValue(key, "my-string", new EvaluationContext(), FlagEvaluationOptions.builder().build()));
assertEquals("gnirts-ym", c.getStringValue(key, "my-string"));
assertEquals("gnirts-ym", c.getStringValue(key, "my-string", new EvaluationContext()));
assertEquals("gnirts-ym", c.getStringValue(key, "my-string", new EvaluationContext(), FlagEvaluationOptions.builder().build()));
assertEquals(4, c.getIntegerValue(key, 4));
assertEquals(4, c.getIntegerValue(key, 4, new EvaluationContext()));
assertEquals(4, c.getIntegerValue(key, 4, new EvaluationContext(), FlagEvaluationOptions.builder().build()));
assertEquals(400, c.getIntegerValue(key, 4));
assertEquals(400, c.getIntegerValue(key, 4, new EvaluationContext()));
assertEquals(400, c.getIntegerValue(key, 4, new EvaluationContext(), FlagEvaluationOptions.builder().build()));
}