Signed-off-by: Tom Carrio <tom@carrio.dev>
Co-authored-by: Meg McRoberts <mmcroberts@cloudbees.com>
Co-authored-by: Matthew Elwell <mjelwell89@gmail.com>
* Fix type checking within client
Signed-off-by: Manuel Schönlaub <manuel.schoenlaub@gmail.com>
* Make linter happy
Signed-off-by: Manuel Schönlaub <manuel.schoenlaub@gmail.com>
* Migrate Hook Hints to Mapping
Signed-off-by: Manuel Schönlaub <manuel.schoenlaub@gmail.com>
* Fix type annotations in FlagEvaluationDetails
Signed-off-by: Manuel Schönlaub <manuel.schoenlaub@gmail.com>
* Fix last hint typing
Signed-off-by: Manuel Schönlaub <manuel.schonlaub@prodigygame.com>
* Rework typing
Signed-off-by: Manuel Schönlaub <manuel.schonlaub@prodigygame.com>
Signed-off-by: Manuel Schönlaub <manuel.schoenlaub@gmail.com>
Signed-off-by: Manuel Schönlaub <manuel.schonlaub@prodigygame.com>
* feature/spec-0.3.0: Update docs on merging contexts to reflect spec
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* feature/spec-0.5.0: Ensure error message is optional and error code required when an error has been found
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* feature/spec-0.5.0: Remove returns in exception docstrings
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* fix/unit-tests: Add float and int flag methods
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* fix/unit-tests: Add the ability for a provider to have hooks
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* fix/unit-tests: Flag evaluation options added for hook merging
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* fix/unit-tests: Move numeric type methods to a private method within the client
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* feature/spec-0.2.0: Add tests for new numeric methods
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* feature/spec-0.2.0: Overwrite init on FlagEvaluationOptions
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* feature/spec-0.2.0: Overwrite init on FlagEvaluationOptions
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* feature/spec-0.2.0: Remove init on FlagEvaluationOptions
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* feature/spec-0.2.0: Ensure before_hooks are evaluated in the opposite order
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* feature/spec-0.2.0: Remove number flag evaluation in favour of strongly typed counterparts
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* feature/spec-0.2.0: Check flag type after provider response
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* feature/spec-0.2.0: Remove unnecessary static method
Signed-off-by: Matthew Elwell <matthew.elwell@flagsmith.com>
* feature/spec-0.2.0: Update docstring parameter name
Signed-off-by: Matthew Elwell <matthew.elwell@flagsmith.com>
* feature/spec-0.2.0: Fix typing of int and float methods
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* feature/spec-0.2.0: Change provider methods to resolves rather than gets
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Co-authored-by: Matthew Elwell <matthew.elwell@flagsmith.com>
* fix/unit-tests: Improve unit test coverage to ensure spec is followed
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* fix/unit-tests: Add test coverage around hooks
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* fix/unit-tests: Parametrize test_should_use_no_op_provider_if_none_provided
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* fix/unit-tests: Parametrize all flag type methods in open feature client
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* fix/unit-tests: Parametrize all flag type methods in open feature client
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* fix/unit-tests: Add fixture to clear global provider after each tests
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* fix/unit-tests: Mock hooks in tests
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* fix/unit-tests: Update docstring on clear_provider method
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* fix/unit-tests: remove setup method in client tests
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* fix/unit-tests: Remove invalid flag type check in private method _create_provider_evaluation and move to public method
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* fix/flag-error-message: Move flag evaluation details to a dataclass and add error message to the class
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* fix/flag-error-message: Rename flag_key in FlagEvaluationDetails to match spec
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* fix/flag-error-message: Rename flag_key in provider.py to match spec
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* fix/flag-error-message: Rename flag_key in open_feature_client.py
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* fix/flag-error-message: Rename flag_key in open_feature_client.py
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* fix/flag-error-message: handle error_message doesn't exist exception
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* hooks: Implementation of hooks for python Open Feature
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* hooks: Fix tests broken as a result of providing hook support
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* hooks: Add api level evaluation context support
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* hooks: Change typing on iterables to be compatible with python 3.8
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* hooks: Add docstring for evaluate_flag_details method
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* hooks: Add docstring for evaluate_flag_details method
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* hooks: docstring change requested in review
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* hooks: add docstrings and comments to
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* hooks: Use correct exception in error hooks in the client
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
* hooks: Set empty evaluation context in no op provider to None
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Tom Carrio