open-telemetry
/
opentelemetry-collector
mirror of https://github.com/open-telemetry/opentelemetry-collector.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[chore] Improve queue config validation messages (#11995) 

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
This commit is contained in:
Bogdan Drutu 2025-01-14 08:44:11 -08:00 committed by GitHub
parent b722821996
commit 2865ff6cc8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
exporter/exporterhelper/internal/queue_sender.go
View File

@ -56,11 +56,11 @@ func (qCfg *QueueConfig) Validate() error {
}
if qCfg.QueueSize <= 0 {
return errors.New("queue size must be positive")
return errors.New("`queue_size` must be positive")
}
if qCfg.NumConsumers <= 0 {
return errors.New("number of queue consumers must be positive")
return errors.New("`num_consumers` must be positive")
}
return nil

4
exporter/exporterhelper/internal/queue_sender_test.go
View File

@ -313,12 +313,12 @@ func TestQueueConfig_Validate(t *testing.T) {
require.NoError(t, qCfg.Validate())
qCfg.QueueSize = 0
require.EqualError(t, qCfg.Validate(), "queue size must be positive")
require.EqualError(t, qCfg.Validate(), "`queue_size` must be positive")
qCfg = NewDefaultQueueConfig()
qCfg.NumConsumers = 0
require.EqualError(t, qCfg.Validate(), "number of queue consumers must be positive")
require.EqualError(t, qCfg.Validate(), "`num_consumers` must be positive")
// Confirm Validate doesn't return error with invalid config when feature is disabled
qCfg.Enabled = false

4
exporter/exporterqueue/config.go
View File

@ -39,10 +39,10 @@ func (qCfg *Config) Validate() error {
return nil
}
if qCfg.NumConsumers <= 0 {
return errors.New("number of consumers must be positive")
return errors.New("`num_consumers` must be positive")
}
if qCfg.QueueSize <= 0 {
return errors.New("queue size must be positive")
return errors.New("`queue_size` must be positive")
}
return nil
}

4
exporter/exporterqueue/config_test.go
View File

@ -15,11 +15,11 @@ func TestQueueConfig_Validate(t *testing.T) {
require.NoError(t, qCfg.Validate())
qCfg.NumConsumers = 0
require.EqualError(t, qCfg.Validate(), "number of consumers must be positive")
require.EqualError(t, qCfg.Validate(), "`num_consumers` must be positive")
qCfg = NewDefaultConfig()
qCfg.QueueSize = 0
require.EqualError(t, qCfg.Validate(), "queue size must be positive")
require.EqualError(t, qCfg.Validate(), "`queue_size` must be positive")
// Confirm Validate doesn't return error with invalid config when feature is disabled
qCfg.Enabled = false