564818fd7f
[chore]: fix testifylint rules ( #12791 )
...
#### Description
Fixes testifylint rules which where disabled with golangci-lint v2
upgrade
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2025-04-02 23:10:07 +00:00
0b978307c2
[chore]: enable gofumpt linter in connector, consumer, exporter, extension and featuregate ( #11854 )
...
#### Description
[gofumpt](https://golangci-lint.run/usage/linters/#gofumpt ) is a
stricter format than gofmt, while being backwards compatible.
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-12-12 19:25:06 +00:00
168a881b3c
fix(deps): update module github.com/golangci/golangci-lint to v1.62.0 ( #11644 )
...
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/golangci/golangci-lint](https://redirect.github.com/golangci/golangci-lint )
| `v1.61.0` -> `v1.62.0` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.
---
### Release Notes
<details>
<summary>golangci/golangci-lint
(github.com/golangci/golangci-lint)</summary>
###
[`v1.62.0`](https://redirect.github.com/golangci/golangci-lint/compare/v1.61.0...v1.62.0 )
[Compare
Source](https://redirect.github.com/golangci/golangci-lint/compare/v1.61.0...v1.62.0 )
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR was generated by [Mend Renovate](https://mend.io/renovate/ ).
View the [repository job
log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45LjUiLCJ1cGRhdGVkSW5WZXIiOiIzOS45LjUiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyIsInJlbm92YXRlYm90Il19-->
---------
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Co-authored-by: Yang Song <songy23@users.noreply.github.com>
Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
Co-authored-by: Yang Song <yang.song@datadoghq.com>
2024-11-13 12:15:45 -08:00
c8005ec855
[chore] Pass the signal constant instead of the string ( #11420 )
...
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2024-10-13 13:21:03 -07:00
77bb849aa0
[component] Refactor to use pipeline.ID and pipeline.Signal ( #11204 )
...
#### Description
Depends on
https://github.com/open-telemetry/opentelemetry-collector/pull/11209
This PR is a non-breaking implementation of
https://github.com/open-telemetry/opentelemetry-collector/pull/10947 . It
adds a new module, `pipeline`, which houses a `pipeline.ID` and
`pipeline.Signal`. `pipeline.ID` is used to identify a pipeline within
the service. `pipeline.Signal` is uses to identify the signal associated
to a pipeline.
I do this work begrudgingly. As the PR shows, this is a huge refactor
when done in a non-breaking way, will require 3 full releases, and
doesn't benefit our [End Users or, in my opinion, our Component
Developers or Collector Library
Users](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CONTRIBUTING.md#target-audiences ).
I view this refactor as a Nice-To-Have, not a requirement for Component
1.0.
<!-- Issue number if applicable -->
#### Link to tracking issue
Works towards
https://github.com/open-telemetry/opentelemetry-collector/issues/9429
2024-09-23 07:38:59 -07:00
37f783308e
[chore]: enable require-error rule from testifylint ( #11199 )
...
#### Description
Testifylint is a linter that provides best practices with the use of
testify.
This PR enables
[require-error](https://github.com/Antonboom/testifylint?tab=readme-ov-file#require-error )
rule from [testifylint](https://github.com/Antonboom/testifylint )
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-09-18 15:02:22 -07:00
6925a306fa
[chore]: enable len and empty rules from testifylint ( #11021 )
...
#### Description
Testifylint is a linter that provides best practices with the use of
testify.
This PR enables
[len](https://github.com/Antonboom/testifylint?tab=readme-ov-file#len )
and
[empty](https://github.com/Antonboom/testifylint?tab=readme-ov-file#empty )
rules from [testifylint](https://github.com/Antonboom/testifylint )
It also adds testifylint as tool to use with a make command
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-09-09 09:57:58 -07:00
fc28929061
move internal/testdata to pdata/testdata ( #9885 )
...
This reduces dependencies from the consumer package while making
testdata available across repos. It will allow us to remove duplicated
code and its a fairly small surface area.
Fixes
https://github.com/open-telemetry/opentelemetry-collector/issues/9886
---------
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
2024-04-08 08:36:57 -07:00
26c157e3bf
[component] Add MustNewType constructor for component.Type ( #9414 )
...
**Description:**
- Adds `component.MustNewType` to create a type. This function panics if
the type has invalid characters. Add similar functions
`component.MustNewID` and `component.MustNewIDWithName`.
- Adds `component.Type.String` to recover the string
- Use `component.MustNewType`, `component.MustNewID`,
`component.MustNewIDWithName` and `component.Type.String` everywhere in
this codebase. To do this I changed `component.Type` into an opaque
struct and checked for compile-time errors.
Some notes:
1. All components currently on core and contrib follow this rule. This
is still breaking for other components.
2. A future PR will change this into a struct, to actually validate this
(right now you can just do `component.Type("anything")` to bypass
validation). I want to do this in two steps to avoid breaking contrib
tests: we first introduce this function, and after that we change into a
struct.
**Link to tracking Issue:** Updates #9208
2024-02-02 17:33:03 +01:00
edf7aca852
Remove circular dependency between default otel and connector ( #9095 )
...
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2023-12-13 23:50:35 -08:00
Matthieu MOREL
renovate[bot]
Bogdan Drutu
Tyler Helmuth
Alex Boten
Pablo Baeyens