<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
<!-- Issue number if applicable -->
Error out on mismatched type for all component kinds. Same as #12305 but
for all component kinds.
#### Link to tracking issue
Requires #12357Fixes#12221
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
<!-- Issue number if applicable -->
Remove deprecated symbols
#### Link to tracking issue
Updates #12222, #12305, #11524
#### Description
At the moment, `receiver`, `scraper`, `processor`, `exporter`, and
`extension` each have their own version of the `MakeFactoryMap`
function, which takes a list of Factories and returns it as a map, with
the component name as the key (and an error if there is overlap).
Because all versions are near-identical except for the Factory type
used, and this function is only used in tests and in the code generated
by OCB (`components.go`), it was suggested to make it generic and move
it to the `otelcol` package.
This PR does exactly that. The old `MakeFactoryMap` functions are
deprecated (and may be removed alongside their tests in a future
release). I also had to make a few other odd changes to fit the new
dependency graph.
#### Link to tracking issue
Resolves#12222
---------
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
<!-- Issue number if applicable -->
Deprecate `Create*` methods. This is a small part of #12305, but applied
to all other component kinds
#### Link to tracking issue
Updates #12221
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This splits the exporter package, so the APIs are in an internal
package, and redefined publicly for logs/metrics/traces.
In preparation for adding profiles to the package.
<!-- Issue number if applicable -->
#### Link to tracking issue
See https://github.com/open-telemetry/opentelemetry-collector/pull/10375
cc @mx-psi
This deprecates CreateSettings in favour of Settings.
NewNopCreateSettings is also being deprecated in favour of
NewNopSettings
Part of #9428
~Follows
https://github.com/open-telemetry/opentelemetry-collector/pull/10333~
---------
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
* [chore] use license shortform
To remain consistent w/ contrib repo, see https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/22052
Signed-off-by: Alex Boten <aboten@lightstep.com>
* make goporto
Signed-off-by: Alex Boten <aboten@lightstep.com>
---------
Signed-off-by: Alex Boten <aboten@lightstep.com>
As we are preparing for Beta release we want to cleanup publicly exported
types and interfaces and do all necessary refactoring and breaking changes
now, before the Beta release. We will have a lot less leeway for breaking
changes after the Beta release.
Component related type declarations are now all in the `component` package.
This makes it possible for the interfaces to reference each other. This
was were very restricted earlier because component interfaces were in 5
different packages and many proposals were impossible to implement because
they would result in circular dependencies between packages.
(An example upcoming new capability that is enabled by this refactoring
is for components to query the Host for other components and for factories).
List of changes in this commit:
- Move all factory interfaces and component interfaces to component package.
- Rename old factories and components interfaces to use "Old" suffix for clarity.
- Eliminate forced checks that components implement factories. This is already
enforced by the compiler when the factory is added to the Defaults() and
was unnecessary code.
- Eliminated some unnecessary codes (removed overall over 200 lines).
- Run `go mod tidy` on testbed.
Warning: this is a breaking change to publicly exported types and function
signatures. We announced that a breaking change is comming. Once we agree
to merge this commit we will need to announce the exact list of changes
and guide component authors to modify their components accordingly.
Future changes:
- Once all components are migrated to the new internal representation,
delete all "Old"-suffixed definitions. This will likely be done while
we are still in Beta phase, before the Stable release.
- Added V2 metric factories and interfaces for receivers and exporters.
- Added V2 factories and interfaces for processors.
- Creation methods in V2 factories accept a CreationParams struct to
allow for easier addition of new parameters in the future without
breaking the interface.
All changes are uniform with previously introduced initial batch of
V2 factories and interfaces (except introduction of CreationParams).
Issue: https://github.com/open-telemetry/opentelemetry-collector/issues/478
1. Introduced data structures that represent telemetry data in-memory.
2. Renamed OTLP* interfaces and types to *V2 types to denote that they are
Internal and not OTLP and are the new version of internal data.
Internal representation is somewhat different from OTLP.
Testing done: unit tests that cover non-trivial functions. Single-line
getters and setters are typically not covered.
Documentation: added doc.go to describe the implementation and usage.
Design doc and benchmarks: https://docs.google.com/document/d/1MSKjMVXQsP51lA6OwpfyLfZhWK-MkGo5vff43LhrqZU/edit#
This change fixes inconsistencies in component interfaces. Motivation:
- Uniformness results in reduction of code that currently has to
deal with differences.
- Processor.Start is missing and is important for allowing processors
to communicate with the Host.
What's changed:
- Introduced Component interface.
- Unified Host interface.
- Added a Start function to processors (via Component interface).
- Start/Shutdown is now called for Processors from service start/shutdown.
- Receivers, Exporters, Processors, Extensions now embed Component interface.
- Replaced StartTraceReception/StartMetricsReception by single Start function for receivers.
- Replaced StopTraceReception/StopMetricsReception by single Shutdown function for receivers.
Note: before merging this we need to announce the change in Gitter since it
breaks existing implementations in contrib (although the fix is easy).
Resolves#477Resolves#262
* INITIAL
* Properly implement name
* reword comment
* address comments and rename stop to shutdown
* Use assert in tests, change to shutdown instead of shutdownFunc and add some missing comments.
* Refactor (Trace/Metrics)ExportFormat to ExporterName
Continuing the refactor that started from exporterhelper in proper naming the related fileds and methods.
* Remove Exporter interface and shorten method names
* Change census-instrumentation to open-telemetry and update authors
census-instrumentation/opencensus is now open-telemetry/opentelemetry
"OpenCensus Authors" is now "OpenTelemetry Authors"
"Copyright 2018" is now "Copyright 2019"
Fix go fmt
- Introduced a new unisvc binary and make target. Unisvc is
planned to be the implementation of the unified agent and collector
that uses the new configuration format.
- Refactored existing Application.execute() code to make it more
readable and also reusable.
The functionality is not changed. Reviews: please check this carefully!
- Introduced new Application.executeUnified() function that will call
all new agent/collector execution logic that is different from
old logic.
Application.executeUnified() is currently partial implementation,
which only builds the exporters. I plan to add building of processor
pipelines and receivers in future PRs.
- Introduced ExportersBuilder which builds runtime exporters based
on provided configuration.
- Added ability for App telemetry shutdown. This is required to be able to
run multiple tests that involve App start and shutdown. Previously
there was only one test - TestApplication_Start - and it was not
correctly cleaning up telemetry resources at the end, making impossible
to add more tests against App.
* Rename [Trace|Metrics]DataProcessor to [Trace|Metrics]Processor
* Rename TraceProcessor to TraceConsumer as discussed.
* Add empty_test for processor.
* Implemented the exporter.TraceExporter interface whose
method
```go
ExportSpanData(*commonpb.Node, ...*trace.SpanData) error
```
is feeds into a transformer that creates a spanreceiver.SpanReceiver
of which that signature
```go
ReceiveSpans(*commonpb.Node, ...*trace.SpanData) (*spanreceiver.Acknowledgement, error)
```
Also provided a dummy transformer which takes trace.Exporter-s and
creates a spanreceiver.SpanReceiver that that is passed to each
interceptor.
* Also provided an end-to-end application which if copied and pasted
is the prototype for our cmd/ocagent code that exports traces to the
various traditional OpenCensus trace.Exporter-s that have grown around
the OpenCensus ecosystem. The config parsing phase will determine
which trace.Exporter-s will be used. In the demo, application,
I am able to send traces to both Stackdriver and Jaeger simultaneously
Example config.yaml:
stackdriver:
project: "projectid"
enableTraces: true
zipkin:
endpoint: "http://localhost:9411/api/v2/spans"
Exporter will export the traces both to Stackdriver
and Zipkin.
Updates #8.
This commit contains an initial prototype for the exporter daemon
that can discovered via and endpoint file on the host.
The exporter looks for the endpoint file to see the availability
of the daemon and exports if it is running.
Exporter daemon will allow OpenCensus users to export
without having to link a vendor-specific exporter in their final
binaries. We are expecting the prototype exporter is going to
be implemented in every language and registered by default.
Updates https://github.com/census-instrumentation/opencensus-specs/issues/72.
Pablo Baeyens
Jade Guiton
Bogdan Drutu
Alex Boten
Damien Mathieu
Alex Boten
Daniel Jaglowski
Tigran Najaryan
Constance Caramanolis
Paulo Janotti
Yang Song
Steve Flanders
Bogdan Drutu
Emmanuel T Odeke
JBD