#### Description
[Thelper](https://golangci-lint.run/usage/linters/#thelper) detects
tests helpers which is not start with t.Helper() method.
This only enables rules for naming and paramter order
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
#### Description
[perfsprint](https://golangci-lint.run/usage/linters/#perfsprint) checks
that fmt.Sprintf can be replaced with a faster alternative.
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
This bug caused proctelemetry metrics to not be registered if a user
configured the Collector's internal telemetry via `readers` only and
disabled `address`. The check in the `if` statement is no longer needed
since a no-op meter provider will be configured unless the telemetry
level is set.
Mentioned in #10919
---------
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
#### Description
Fixing the bug: the latest version of otel-collector failed to start
with ipv6 metrics endpoint service telemetry.
This problem began to occur after
https://github.com/open-telemetry/opentelemetry-collector/pull/9037 with
the feature gate flag enabled was merged. This problem is probably an
implementation omission because the enabled codepath, which was
originally added by
https://github.com/open-telemetry/opentelemetry-collector/pull/7871, is
marked as WIP.
You can reproduce the issue with the config and the environment variable
(`MY_POD_IP=::1`).
```yaml
service:
telemetry:
logs:
encoding: json
metrics:
address: '[${env:MY_POD_IP}]:8888'
```
#### Link to tracking issue
Fixes
https://github.com/open-telemetry/opentelemetry-collector/issues/10011
---------
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
This enables end users to configure additional prometheus exporters for
the collector's telemetry
via the `readers` configuration option. Configuring prometheus through
the existing method
of setting the service::metrics::address will continue to work, and only
log a warning for users
who have enabled the
`telemetry.useOtelWithSDKConfigurationForInternalTelemetry` feature
gate.
Linked issue: #7641
---------
Signed-off-by: Alex Boten <aboten@lightstep.com>
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
* [chore] use license shortform
To remain consistent w/ contrib repo, see https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/22052
Signed-off-by: Alex Boten <aboten@lightstep.com>
* make goporto
Signed-off-by: Alex Boten <aboten@lightstep.com>
---------
Signed-off-by: Alex Boten <aboten@lightstep.com>
* chore: adds porto and fixes vanity imports.
* chore: fixes target overriding.
* chore: fixes install of porto.
* chore: includes porto as a tool.
* chore: upgrades porto to check internals.
* chore: rebase and update vanity import.
* chore: removes unnecessary space.
* chore: rollsback vanity import in generated files.