Commit Graph

17 Commits

Author SHA1 Message Date
Dmitrii Anoshin e4cfde4758
[pdata] Rename MetricAggregationTemporality to AggregationTemporality (#6253)
As a new rule we want to rename all the structs for proto messages defined at the package level to not have the owner prefix in its name.
2022-10-07 09:37:47 -07:00
Dmitrii Anoshin 7740c7b387
Remove usages of deprecated pdata Clone methods (#6170) 2022-09-28 18:25:22 -07:00
Bogdan Drutu 1a4361c49a
Remove unnecessary and unused testdata (#5599)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2022-06-27 09:43:33 -07:00
Dmitrii Anoshin 734e25e8de
Split `model` by signal type and move it to the new `pdata` module (#5168)
Split all `pdata` related code by type and move it from `model` to the new module `pdata`.

- `model/pdata` and `model/otlp` are moved to `pdata/plog`, `pdata/pmetric` and `pdata/ptrace`.
- `model/otlpgrpc` is moved to `pdata/plogotlp`, `pdata/pmetricotlp` and `pdata/ptraceotlp`.

Now all the API in `model` except for `model/semconv` is deprecated.
2022-04-11 16:00:26 -07:00
Alex Boten 1d5fdd1c1f
Deprecation of pdata methods following OTLP v0.15.0 (#5076)
* Deprecation of pdata methods following OTLP v0.15.0

Adding deprecation methods for the following pdata methods:
  - InstrumentationLibrary is now Scope
  - InstrumentationLibrarySpans is now ScopeSpans
  - InstrumentationLibraryLogs is now ScopeLogs
  - InstrumentationLibraryMetrics is now ScopeMetrics

* update changelog

* add deprecated method on resource spans/metrics/logs

* add InstrumentationLibrary deprecation method
2022-03-28 00:32:48 -07:00
Bogdan Drutu 1a58ddab2c
Update batch processor to handle ExponentialHistogram (#4405)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2021-11-12 09:25:31 -08:00
David Ashpole a9df2ae27b
unit test and changelog follow up to batch processor descriptor fix (#4396) 2021-11-10 16:34:45 -08:00
David Ashpole 719d371a56
copy aggregation temporality and monotonic to new metric batches (#4389) 2021-11-10 10:13:59 -08:00
Bogdan Drutu 6785e6fdd8
Fix small nits in the batchprocessor split logic (#4340)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2021-11-02 12:09:47 -07:00
Bogdan Drutu 87405ddaa4
Small cleanup for batchprocessor split logic (#4284)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2021-10-28 08:49:51 -07:00
Traian Schiau fd61bbbc9b
pdatagen - Add MoveTo method for struct types (#4240)
* [pdatagen] Add MoveTo method for struct types

* [pdatagen] Add MoveTo method for struct types - regenerate

* [batchprocessor] Split benchmarks rework

- Fix metric split benchmark
- Ignore clone counters in split benchmarks

* [batchprocessor] Use MoveTo in split

* [batchprocessor] Skip long running split benchmarks

* [batchprocessor] Improve coverage
2021-10-27 10:18:54 -07:00
Anthony Mirabella 9e8bded5b4
Deprecate Resize() from pdata slice APIs (#3573)
* Remove Resize() from pointer slice API

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>

* model/pdata: refactor value slice interfaces

* Removed Resize()
* Added EnsureCapacity() and AppendEmptyN()

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>

* -Fix function signature in cpu_scraper_linux.go

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>

* Fix remaining Resize() calls

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>

* Fix OS-specific processes scraper

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>

* Remove tests for equality of value slices that aren't comparable

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>

* Remove AppendEmptyN from pdata slice APIs

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>

* batchprocessor: improve splitMetric() to avoid copying entire metric unless necessary

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>

* model/pdata: restore Resize() for slice types, mark as deprecated

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>

* Update metrics_test.go

* Update metrics_test.go

Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
Co-authored-by: Bogdan Drutu <lazy@splunk.com>
2021-07-12 19:01:24 -07:00
Bogdan Drutu c63d0c68cd
Move pdata in the new package (#3483)
The new module go.opentelemetry.io/collector/model will be created later when the internal data will
also be moved.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2021-06-25 01:17:31 +03:00
kisieland 6d44f0d303
Make the batch processor limit data points rather than metrics. (#3141)
**Link to tracking Issue:** #2754

This change introduces a BenchmarkBatchMetricProcessor that stress tests batching logic.
Results before:
`BenchmarkBatchMetricProcessor-12           20000             80614 ns/op`
Results after the change:
`BenchmarkBatchMetricProcessor-12           20000             96184 ns/op`
2021-06-02 10:52:24 -04:00
Bogdan Drutu deceea9d54
Fix batch processor metrics reorder, improve performance (#3034)
Benchmarks Before:
```
goos: darwin
goarch: amd64
pkg: go.opentelemetry.io/collector/processor/batchprocessor
cpu: Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
BenchmarkSplitMetrics
BenchmarkSplitMetrics-16    	    6660	    170653 ns/op	  182889 B/op	    3309 allocs/op
PASS

Process finished with the exit code 0
```

Benchmarks After:
```
goos: darwin
goarch: amd64
pkg: go.opentelemetry.io/collector/processor/batchprocessor
cpu: Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
BenchmarkSplitMetrics
BenchmarkSplitMetrics-16    	    7858	    134259 ns/op	  141881 B/op	    2596 allocs/op
PASS

Process finished with the exit code 0
```

Benchmarks Reference Clone:
```
goos: darwin
goarch: amd64
pkg: go.opentelemetry.io/collector/processor/batchprocessor
cpu: Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
BenchmarkCloneMetrics
BenchmarkCloneMetrics-16    	    8726	    127948 ns/op	  137816 B/op	    2503 allocs/op
PASS

Process finished with the exit code 0
```

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2021-05-05 13:55:36 -07:00
Bogdan Drutu 13e45667cf
Cleanup usages of Resize(1), after PR #2970 (#2971)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2021-04-20 18:04:31 -07:00
Daniel Dyla e479242ac7
Support max batch size for metrics (#2422)
* Support max batch size for metrics

* send batch max supported by trace and metric

* Avoid extra allocations
2021-02-09 12:28:23 -08:00