Commit Graph

9 Commits

Author SHA1 Message Date
Bogdan Drutu 937d1e6d25
Replace MetricDataType with MetricType (#6127)
* Dreprecate old APIs, add new APIs without "Data"

Updates https://github.com/open-telemetry/opentelemetry-collector/issues/6081

Signed-off-by: Bogdan <bogdandrutu@gmail.com>

Signed-off-by: Bogdan <bogdandrutu@gmail.com>
2022-09-20 17:06:49 -07:00
Dmitrii Anoshin 0075f95c2e
[pdata] Make wrappers primitive slices mutable (#5971)
Change API for primitive slice wrappers to allow changing items as it appeared to be expensive to update that data as immutable wrappers: it requires making two copies to update a slice
2022-09-09 11:15:27 -07:00
Bogdan Drutu afffe223ed
[chore] remove unnecessary ctor func, clarify errors (#6032)
Signed-off-by: Bogdan <bogdandrutu@gmail.com>

Signed-off-by: Bogdan <bogdandrutu@gmail.com>
2022-09-09 10:49:54 -07:00
Bogdan Drutu 35cf596fc1
Deprecate pmetric.Metric.SetDataType, in favor of empty setters (#5979)
Signed-off-by: Bogdan <bogdandrutu@gmail.com>

Signed-off-by: Bogdan <bogdandrutu@gmail.com>
2022-09-07 23:16:48 -07:00
Bogdan Drutu 9d8519c967
Remove deprecated funcs for pmetric (#6017)
Signed-off-by: Bogdan <bogdandrutu@gmail.com>

Signed-off-by: Bogdan <bogdandrutu@gmail.com>
2022-09-02 12:53:13 -07:00
Bogdan Drutu 9b162b70b5
Change TraceID and SpanID to be type def of an array (#6008)
Signed-off-by: Bogdan <bogdandrutu@gmail.com>

Signed-off-by: Bogdan <bogdandrutu@gmail.com>
2022-09-02 08:38:16 -07:00
Bogdan Drutu 72011ca22d
Change MetricDataPointFlags to the new immutable pattern (#5999)
Signed-off-by: Bogdan <bogdandrutu@gmail.com>

Signed-off-by: Bogdan <bogdandrutu@gmail.com>
2022-08-30 16:03:26 -07:00
Bogdan Drutu a3c63bb8a6
Simplify implementation for trace ids, no public API changes (#5968)
Signed-off-by: Bogdan <bogdandrutu@gmail.com>

Signed-off-by: Bogdan <bogdandrutu@gmail.com>
2022-08-29 09:51:27 -07:00
Bogdan Drutu 58fa059da5
Change pdata generated types to use type definition instead of aliases (#5936)
Change the way how objects are generated in `pdata`. Previously the pdata objects were generated in the `internal` package and aliases were created in the public packageas.

This PR changes this, by creating only "wrappers" object inside the internal package, and the public type is a type def of the internal type:

```golang
package internal

type LogRecord struct {
	orig *otlplogs.LogRecord
}

func GetOrigLogRecord(ms LogRecord) *otlplogs.LogRecord {
	return ms.orig
}

func NewLogRecord(orig *otlplogs.LogRecord) LogRecord {
	return LogRecord{orig: orig}
}
```

```golang
package plog

type LogRecord internal.LogRecord
```

With this approach, we still do not allow users access to the internal origin, which allows us flexibility to change to other representation (something like lazy proto, etc), but improves documentation of the pdata packages, see [current documentation](https://pkg.go.dev/go.opentelemetry.io/collector/pdata@v0.58.0/plog).

Signed-off-by: Bogdan <bogdandrutu@gmail.com>

Signed-off-by: Bogdan <bogdandrutu@gmail.com>
2022-08-24 16:32:05 -07:00